Attempting to upload an icon.ico hangs the setup page button to “uploading…” without any indication that it isn’t supported.
Replicate with https://thebobsgamingnetwork.net/favicon.ico and a fresh install of discourse.
1개의 좋아요
Yeah, the problem is that ico is not among the extensions authorized at the first start (it can be added later). We should add the authorized extensions to the wizard
4개의 좋아요
ICO is an obsolete format for the web – I strongly recommend using simple PNG or JPG instead.
4개의 좋아요
I think it’s better to show a proper error message since ICO are deprecated…
5개의 좋아요
Can we give this to @techAPJ? All we need to do is show an educational panel if someone tries to upload an obsolete ICO file.
2개의 좋아요
We will now show proper error message (received from server side) when upload fails in wizard and re-enable the upload button. This issue was applicable on “Logos” step too.
https://github.com/discourse/discourse/commit/bd760e98af86f541080d49eab1633094e945dec9
Demo:
I also updated the help text on “Icons” step to indicate recommended image extensions.
5개의 좋아요