Uploading files with longer file extensions gets truncated
Natanael_Ceder is experiencing an issue with uploading files that have long file extensions, which gets truncated. The issue is not just limited to long extensions, as all file extensions seem to be truncated to a maximum of 10 characters, as seen in Natanael_Ceder’s example.
Natanael_Ceder investigated the source code and found a potential cause in the uploads_controller.rb file, which has a 50 character limit.
However, blake discovered that the actual issue is not the length of the extension, but rather the presence of - and uppercase letters. A fix has been created in a GitHub commit, which resolves the issue by ensuring that the actual downloaded file has the full file extension, even if the link is truncated.
Natanael_Ceder is looking forward to the next release, which will include the fix.
Hi!
when trying to upload a file with “long” file extensions, it seems like the upload filename gets “truncated”
but links to “/uploads/short-url/3xMz4QHB9JcqXACwwn1S5ZgMi2t.MaxxECU-Zi” which is of course wrong and we get an “oops! that page does not exist or is private”.
Is there anyone who has seen this one before, and has some idea what to change to get this sorted?
Thanks in advance.
I checked the source and it could be the 50 character limit in app\controllers\uploads_controller.rb
line 20
Just wanted to let you know that a fix for this has been created:
https://github.com/discourse/discourse/commit/44153cde18e4f4f3d3c5719e3e7c96b5954f25c8
The issue that I resolved actually was the - and uppercase letters in the extension and not the length. The link to download the file will still be truncated, but the actual file you download will have the full file extension.
Ah, thank you!
Looking forward to the next release then.
This topic was automatically closed after 2 days. New replies are no longer allowed.
