Really excellent theme component! Is there any way to display banners for lists that are using both a category and tag simultaneously?
1 个赞
Not at the moment… at some point it probably does make sense to combine this tag component with the category banner component… then where the banners are shown can probably be handled in the theme settings if someone wants it one way or another.
3 个赞
I think I found a way. I will post a PR tonight probably if I manage to get it work.
Edit: Alright PR is ready
master ← radek3911:master
merged 03:12PM - 04 Dec 20 UTC
Hello,
I have discovered a bug within this component. To sum it up if you ope… n category and select tag the tag banner wont show because of different routes. If you click the tag and open the tag page (route starting with /tag/) you get the banner, while the categories have route starting with /tags/ and a different controller.
This PR also serves as a feature request to this comment:
https://meta.discourse.org/t/discourse-tag-banners/124240/14
**Please squash commits if you are going to merge...**
Thanks
5 个赞
Fantastic! @radek3911 !
3 个赞
我刚刚对这个组件进行了一次更新，使其能更好地与 分类横幅 集成。
main ← category-integration
opened 07:42PM - 24 Apr 23 UTC
This pairs with the category banner update https://github.com/discourse/discours… e-category-banners/pull/32
This utilizes the category banner component's presence service to determine when and how to render tag banners.
The `<DiscourseTagBanners />` component is mounted in the category banner's `category-banners-after-title` outlet, and the category banner presence dictates whether the component displays `<DiscourseTagBannersTextOnly />` or `<DiscourseTagBannersPresentation />`
The category banner's presence service also determines whether or not the tag banner will show at all in the `above-site-header` and `below-site-header` outlets, so we don't end up with a category banner stacked with a tag banner.
当安装了这两个组件，并且你筛选了某个分类和一个标签时，横幅将不再堆叠，而是标签名称会显示在分类横幅内：
当只筛选某个标签时，标签横幅仍会按预期显示。
10 个赞
Thanks @radek3911!
