I’ve tracked down the change that causes the issue, not sure why it was changed here:
https://github.com/discourse/discourse/commit/246f77c98d48df011a2e80ae5d33bee1104b6366
I tested it on my install, reverting the above change, using the overage variable like it was before, causes the user card to display properly.
My question for @sam is why change it?
PR for fix:
https://github.com/discourse/discourse/pull/3205
It was rendering offscreen in certain browser widths afaik.
That makes sense, as to why the original solution wouldn’t work. Though what you changed it to definitely didn’t fix the issue.
Do you know what browsers it was having trouble with? I can modify my fix to accommodate those browsers.
Can you test this on a site with a custome header like https://discuss.howtogeek.com/ at various widths. I think chrome exhibited the issue at very particular widths.
Current behavior
Using overage
Window width: 854px (was lowest width to have multiple users in users column)
I also tested in Firefox and Safari and the behavior was consistent, for what it’s worth.
I will pull this in and keep an eye on it, thanks!
As an FYI, I found the issue after adding the user card markup to the last poster info on my version of the minimal theme. Since the last poster is on the far right, it was always going over the edge.
Wow - damn - there’s a bloody big picture of me.
That was unexpected!
Here’s one of @codinghorror and @sam talking
This topic was automatically closed after 61 minutes. New replies are no longer allowed.
