Canapin
(Coin-coin le Canapin)
26 أكتوبر 2020، 5:49م
1
User cards toggled from the online user list are partially hidden by the header.
I suppose it is because of the new header CSS , and the card Y position calculation doesn’t take the header height into account.
I don’t have this issue on my other forum, which isn’t updated yet:
إعجاب واحد (1)
Oh yes, that does seem to be the problem… though it’s a bit odd that it isn’t a problem in the topic list? Looking into a fix.
إعجاب واحد (1)
Canapin
(Coin-coin le Canapin)
26 أكتوبر 2020، 10:49م
5
What do you mean? I encounter the issue on any page.
Note that it’s only when I click a user in the who’s online user list since the content is close to the header.
إعجاب واحد (1)
oh sorry that wasn’t clear, I meant it’s odd that positioning is only off in the plugin and seems ok within the topic list itself.
I’ve got a fix in the queue that should improve the positioning:
master ← awesomerobot:user-card-position-fix
merged 01:35AM - 27 Oct 20 UTC
Due to the header changes (fixed => sticky) we no longer need to worry about the… main-outlet offset here.
Before:
<img width="706" alt="Screen Shot 2020-10-26 at 8 49 53 PM" src="https://user-images.githubusercontent.com/1681963/97243518-de94e800-17cc-11eb-9a9f-d4d01420a5d9.png">
After:
<img width="735" alt="Screen Shot 2020-10-26 at 8 50 08 PM" src="https://user-images.githubusercontent.com/1681963/97243533-e48ac900-17cc-11eb-8224-b355205a4dd3.png">
3 إعجابات
Canapin
(Coin-coin le Canapin)
29 أكتوبر 2020، 9:04م
8
I’ve upgraded Discourse, but there are still issues:
For websites with a custom header on top of Discourse’s header, which is quite frequent I believe, the card position seems (I’m not sure this is the reason) to erroneously take the custom header height into account, so the card is is displayed a bit too low:
Cards at the very bottom of the window are off-screen:
إعجاب واحد (1)
There have been some positioning fixes made over the past weeks, it looks like positioning is ok on unicylist now? Can you confirm when you get a chance? (love the loading unicycle btw)
إعجابَين (2)
Canapin
(Coin-coin le Canapin)
25 نوفمبر 2020، 12:19م
10
The card top position seems to ignore Discourse’s header height:
Alson clicking an avatar at the bottom of the screen makes the card to be a bit off-screen:
I’m on 2.6.0.beta6
إعجاب واحد (1)