User preferences: plugin-outlet "user-preferences-desktop-notifications" not translated

claas · 18 mei 2018 om 14:47

I noticed that the text “Prefer push notifications on desktop” in the user preferences here on meta is not localised:

The relevant code is here:

app/assets/javascripts/discourse/templates/preferences/notifications.hbs

008480127


      
            <div class="controls controls-dropdown">
              <label>{{i18n 'user.like_notification_frequency.title'}}</label>
              {{combo-box valueAttribute="value" content=likeNotificationFrequencies value=model.user_option.like_notification_frequency}}
            </div>
          </div>
          
          <div class="control-group desktop-notifications">
            <label class="control-label">{{i18n 'user.desktop_notifications.label'}}</label>
            {{desktop-notification-config}}
            <div class="instructions">{{i18n 'user.desktop_notifications.each_browser_note'}}</div>
            {{plugin-outlet name="user-preferences-desktop-notifications" args=(hash model=model save=(action "save"))}}
          </div>
          
          {{#if siteSettings.enable_personal_messages}}
            <div class="control-group private-messages">
              <label class="control-label">{{i18n 'user.private_messages'}}</label>
          
              <div class="controls">
                {{preference-checkbox
                    labelKey="user.allow_private_messages"
                    checked=model.user_option.allow_private_messages}}

Is this a “Discourse Meta”-specific plugin outlet?

claas · 18 mei 2018 om 14:49

Ah, I just found here that this comes in fact from the official discourse-push-notifications plugin:

https://github.com/discourse/discourse-push-notifications/blob/master/assets/javascripts/discourse/templates/components/push-notification-config.hbs#L6

github.com/discourse/discourse-push-notifications

config/locales/client.en.yml

a3f2c0a28


      
          en:
            js:
              discourse_push_notifications:
                note: "Prefer push notifications on desktop"

So it just doesn’t seem to be on Transifex yet. Who can fix this?

Topic		Antwoorden	Weergaven
Can't keep desktop push notifications enabled - dup Bug	9	1388	11 februari 2021
Translation missing for discourse push notifications Bug	4	790	18 april 2019
Discourse Push Notifications for Desktop Plugin official , included-in-core	3	14858	24 augustus 2025
New notification permissions request bar? UX	34	2065	3 oktober 2018
[en.user.desktop_notifications.currently_disabled] in user profile UX	4	609	28 augustus 2019

User preferences: plugin-outlet "user-preferences-desktop-notifications" not translated

Gerelateerde topics