Users are not added to the moderators groups when registering with SSO

fefrei · 12 مايو 2016، 4:55م

The issue is still there in version v1.6.0.beta4 +161

The same effect occurs if an existing user is given moderator privileges by another SSO sign-in.

After snooping around in the code, could this be because SSO simply sets the flag and saves the user…

app/models/discourse_single_sign_on.rb

19ca08857


      
              user.save!
              user.enqueue_welcome_message('welcome_user') unless suppress_welcome_message
            end
          
            custom_fields.each do |k,v|
              user.custom_fields[k] = v
            end
          
            user.ip_address = ip_address
            user.admin = admin unless admin.nil?
            user.moderator = moderator unless moderator.nil?
          
            # optionally save the user and sso_record if they have changed
            user.save!
            sso_record.save!
          
            sso_record && sso_record.user
          end
          
          private

…while the proper “grant moderation” action…

github.com/discourse/discourse

app/models/concerns/roleable.rb

be3a5a56c


      
          # any user that is either a moderator or an admin
          def staff?
            admin || moderator
          end
          
          def regular?
            !staff?
          end
          
          def grant_moderation!
            set_permission('moderator', true)
          end
          
          def revoke_moderation!
            set_permission('moderator', false)
          end
          
          def grant_admin!
            set_permission('admin', true)
          end

…runs this refresh?

github.com/discourse/discourse

app/models/concerns/roleable.rb

be3a5a56c


      
              set_permission('admin', true)
            end
          
            def revoke_admin!
              set_permission('admin', false)
            end
          
            def save_and_refresh_staff_groups!
              transaction do
                self.save!
                Group.refresh_automatic_groups!(:admins, :moderators, :staff)
              end
            end
          
            def set_permission(permission_name, value)
              self.send("#{permission_name}=", value)
              save_and_refresh_staff_groups!
            end
          
          end

الموضوع		الردود	مرات العرض
SSO users aren't automatically added to email domain-based groups Bug	7	1688	5 يوليو 2018
Groups not being added to new users SSO	3	1898	31 يوليو 2017
SSO and Restricted Groups SSO	2	2909	1 مارس 2017
Two Discourses with SSO: avoid admin/moderator sync Support	6	657	30 أبريل 2023
SSO is forcibly creating the user as an admin Bug	13	1116	17 سبتمبر 2021

Users are not added to the moderators groups when registering with SSO

الموضوعات ذات الصلة