Version check is incorrectly comparing stable and beta versions

バグ
1

We’ve just updated to Discourse 2.5 (stable version), and this component (as well as the new Topic Thumbnails one) is still disabled:

disabled
disabled700×473 50.5 KB

Help!

「いいね！」 2
2

Hi Chris - thanks for this. Looks like we have a bug in our version check code. 2.5.0 should be considered greater than 2.5.0.beta2, but right now it’s not. That’s what is causing the theme to be auto-disabled.

I just opened a PR with a fix:

https://github.com/discourse/discourse/pull/10135

I’m going to split this into its own topic, and will let you know once the fix is live in the stable branch.

「いいね！」 9
3

That’s now merged, so the theme version check should work correctly now. @cjk77 head to /admin/upgrade to update (you won’t receive a new version notification straight away)

「いいね！」 4
4

@cjk77 I have updated your forum and that message has disappeared now.

@david thanks!

「いいね！」 4
5

Confirmed to be working as intended! Thank you both @david and @RGJ!!!

「いいね！」 3