过长的`title`设置阻碍了备份的进行

错误
1

When you configure a title longer than X characters, it will prevent backups from being made.

EXCEPTION: /var/www/discourse/lib/discourse.rb:139:in 'exec': rm: cannot remove '/var/www/discourse/public/backups/default/redacted-xxx(...)xxx-2025-01-17-125027-v20250116024516.tar': File name too long

Yes, people really do that.

Proposed fix

    def get_parameterized_title
      SiteSetting.title.parameterize.presence[..64] || "discourse"
    end
4 个赞
2

Well they shouldn’t!

I suppose your point is that this is yet another case that I should not tell them that they are wrong.

2 个赞
3

Fix may need refinement:

> "".parameterize.presence[..64]
NoMethodError: undefined method `[]' for nil

This should work though.

SiteSetting.title.parameterize[...64].presence || "discourse"

We probably should revisit if we are comfortable with the current max length limit for site titles @hugh

cc @gerhard

5 个赞
4

Will be fixed with:

5 个赞
5

Thank you so much for the info.

6

This topic was automatically closed after 2 days. New replies are no longer allowed.