Viewing mentions at group's activity page is broken

AI-generated summary

A bug was reported where clicking on Mentions at a group’s activity page, such as g/community-moderators/activity, results in an error. The issue was confirmed by ondrej and acknowledged by nat. After investigation, Arkshine identified the cause as a side effect of a commit that changed the output format for /posts but not for /mentions. A pull request (#27066) was created to fix the issue.

Further testing by Moin revealed another issue where only the first 20 results are loaded and scrolling further repeats the same results. This was attributed to the client using before instead of before_post_id for infinite loading. A second pull request (#27070) was created to address this issue.

When you click on Mentions at a group’s activity page like g/community-moderators/activity, it doesn’t work:

The experience is worse when you try to open the mentions in a new tab.

6 Likes

I can repro this too.

3 Likes

Thanks for the report, we’ll prioritise fixing this. :+1:t2:

3 Likes

Having a quick look :eyes:

2 Likes

It looks like a side effect of

https://github.com/discourse/discourse/commit/1deeff2336a3d9180ec6276a8fd5b399ec6165c8

The output format in the group’s controller changed for /posts, but not for /mentions.

3 Likes

Thanks @Moin for the report :+1:
Thanks @Arkshine for the link to the related change :+1:

This will be fixed by :point_down:

https://github.com/discourse/discourse/pull/27066

5 Likes

I have just tried this, and it appears that only the first 20 results are loaded. When scrolling further, the same 20 results seem to be repeated.

3 Likes

Nice catch @Moin :clap:

The client is using before instead of before_post_id to do the infinite loading :hourglass_flowing_sand:

This will be fixed by :point_down:

https://github.com/discourse/discourse/pull/27070

4 Likes

This topic was automatically closed after 21 hours. New replies are no longer allowed.