Moin
14 oktober 2025 om 13:56
1
When you configure an avatar flair on a group that is not visible to everyone, a warning is shown telling staff that this will make the group visible:
Since this group has flair for its members, the name ‘TestGroup’ will be visible to anyone.
But this warning no longer shows up when you upload an image instead of using an icon.
I think it should show up in this case too
privateGroupNameNotice(visibilityLevel, isPrimaryGroup, hasFlair) {
if (visibilityLevel === 0) {
return;
}
if (isPrimaryGroup) {
return i18n("admin.groups.manage.alert.primary_group", {
group_name: this.model.name,
});
} else if (hasFlair) {
return i18n("admin.groups.manage.alert.flair_group", {
group_name: this.model.name,
});
}
}
But somehow hasFlair seems to be false for image uploads. So there is probably something wrong with that
I also wonder why this warning isn’t shown when you create a new group
3 likes
tgxworld
16 oktober 2025 om 04:41
2
I’ve tagged this pri-medium
Hi @Moin ,
Do you have any specific repro steps or a special configuration? I have tested it locally, and I wasn’t able to reproduce this.
Hi @Moin ,
This you have been fixed here. Let me know if you encounter any other issues
main ← fix-flair-warning-on-reload
opened 02:03PM - 16 Oct 25 UTC
**Description**
When visiting a group's membership settings or reloading the … page after uploading a flair image for a group with limited visibility (ie, not everyone), the warning about group name visibility was missing. This occurred because the code checked `flair_upload_id` instead of `flair_url` since `flair_upload_id` is not set.
**Before**
<img width="1136" height="908" alt="imagen" src="https://github.com/user-attachments/assets/73231fd0-4dd3-403f-928c-cd3d34641dc5" />
**After**
<img width="1355" height="1019" alt="imagen" src="https://github.com/user-attachments/assets/839efa62-2f90-4e83-b9dc-2bc34900ffab" />
1 like
Moin
16 oktober 2025 om 15:18
6
Did you also have the chance to look into why the warning isn’t displayed when you create a new group? I think it would be helpful to see the warning right when you create a non-public group with a flair too.
I didn’t tested this way but I can tell that the issue is the component used to display this is not present in the creation form, I will take a look.
1 like
