Moin
July 8, 2024, 9:00pm
1
I noticed this button:
I don’t remember seeing it before and it seems to do nothing.
2 Likes
The gear button should appear for those with sufficient privilege and is intended to show a poll admin a list of possible actions, e.g. to close the Poll.
It should not show for those who have no possible actions.
Virtually the entire poll plugin was migrated to Glimmer last week.
This looks like a minor regression.
I’ve raised a PR and will look to complete it tomorrow. (it works but missing unit tests)
main ← merefield:poll_cog_button_fix
merged 03:19AM - 11 Jul 24 UTC
relates to #27204
see: https://meta.discourse.org/t/what-is-the-gear-button-… under-the-poll-for/315477/2
During migration of Poll plugin from widget basis to glimmer, some functionality was inadvertently dropped:
* A single button should appear instead of the dropdown menu when there is only one valid "poll admin" action
* No button should appear when there are no valid "poll admin" actions for current user
This PR restores the original behaviour and adds test coverage (that didn't exist prior to migration, partly why it wasn't caught earlier)
8 Likes
Moin
July 11, 2024, 7:09am
3
Gears have disappeared. Thanks for fixing!
4 Likes
This topic was automatically closed after 47 hours. New replies are no longer allowed.