What is the meaning of the green check marks on the upgrade page?

AI-generated summary

The green check marks on the Discourse upgrade page indicate that a plugin is an official plugin maintained by Discourse, as explained by itsbhanusharma. However, users found the meaning of these green checks unclear, with some suggesting the addition of a tooltip for better understanding. zogstrip initially mentioned adding a tooltip but later realized it already existed. The tooltip was further improved with a title by zogstrip.

Some users, including pfaffman, suggested replacing the green check with the Discourse logo for better clarity. Although Font Awesome does offer a Discourse icon, as pointed out by david, updating the icons would require changes, as mentioned by Falco.

Additionally, pfaffman raised a concern about the potential for confusion if someone forks an official plugin or creates a plugin with the same name, making it appear as an official plugin. zogstrip acknowledged this possibility but stated that the green check is just an indicator and that people could manipulate the official? method to return true.

I’ve noticed in my own Discourse installation that some weeks ago green checkmarks started to appear on the left of most of the entries on the upgrade page:

I did a search here and also tried to hover over the icons. Still, I don’t understand what they mean.

What makes me wonder is:

  • The main Discourse entry never has a green check mark, no matter whether up-to-date or not.
  • The other items always have a green check mark, no matter whether up-to-date or not.

My question:

What is the meaning of the green check marks on the upgrade page?

1 Like

Those green checks mean that the plugin is an official plugin maintained by Discourse

7 Likes

Thanks. Maybe a mouse hover tooltip could be useful?

3 Likes

There should definitely be a tooltip there. Will add it.

Wait, it already has a tooltip…

5 Likes

I couldn’t figure out what the check meant either. It would be more obvious if the glyph could be the discourse logo.

(and I didn’t notice the hover either)

3 Likes

I figured it was for official, but hovering over for a tooltip doesn’t work - ALT tags (if I recall correctly) only show up if the image is broken

2 Likes

Ok, it now has a title as well :wink:

https://github.com/discourse/docker_manager/commit/c5a371e4e45e8f59632e302d6513162a2cb5263b

10 Likes

I just did an update and I’m not seeing a tooltip. When is Font Awesome going to add a Discourse icon?

Edit: I see them on the Plugin page. I was looking on the upgrade page.

(But I still find the check a confusing way to say “Official Discourse”.)

2 Likes

That would be handy :wink:

9 Likes

Since the Nice People at Font Awesome went to all that trouble, could you change that mysterious :white_check_mark: into a calming, satisfying, and reassuring :discourse:?

3 Likes

That would need https://meta.discourse.org/t/updating-font-awesome-icons/19352/10

2 Likes

That’s what I thought, and then I thought that since since I have :discourse: here that it could also be put on the plugins screen.

2 Likes

The way that I read discourse/lib/plugin/metadata.rb at main · discourse/discourse · GitHub it looks like if someone forks an official plugin, or even has their own plugin with the same name, it’ll look official.

Am I right? Is this a problem?

2 Likes

You are.

It’s just an indicator.

People could easily write a plugin that would overwrite the official? method to return true.

4 Likes