As seen in the picture below, there is a large space below the text “What would you like to do with your post?” when clicking the trashcan in the topic composer. Nothing seems to be there, but it this intentional?
I’m on an Android A14, using Chrome.
P.S. The image caption says “a Reddit post”
3 إعجابات
Moin
9 نوفمبر 2024، 7:41ص
2
I think increasing the modal size was intentional
discourse:main ← discourse:dmenu-modal-styling-tweaks
opened 08:21AM - 21 Oct 24 UTC
To prevent the DMenu on mobile to be too minimal, we're adding a minimum height … of 45% viewport.
In addition, we're implementing a small grip element to highlight the pulldown/swipedown functionality that is already implemented, to close the menu.
<img width="361" alt="CleanShot 2024-10-21 at 17 17 37@2x" src="https://github.com/user-attachments/assets/9a13abf1-a20d-462e-b148-89905aa11ef4">
But I agree that the gap looks odd.
5 إعجابات
chapoi
20 نوفمبر 2024، 10:34ص
10
You know what, guys? You’re kinda right. We did it to avoid tiny bottom modals, somewhat because some people complained the new navigation filter on mobile was too far down. But I agree it’s not ideal in many other situations, so I’ll have a look into reverting it or doing something else.
3 إعجابات
Thanks, looking forward to this!
إعجاب واحد (1)
chapoi
21 نوفمبر 2024، 2:25ص
12
Reverted the min-height and stacked the buttons instead.
discourse:main ← discourse:dmenu-add-modifier
opened 11:39AM - 20 Nov 24 UTC
This commit removes the min-height for the DMenu modals again, as this wasn't an… ideal solution after all.
Instead, we can stack the buttons where applicable by using a `--stacked` modifier, thereby increasing the height of the modal in a more natural way, while also providing a better UI in general.
Example:
There’s still a lot of work on various modals on mobile, but we’re slowly working our way through them.
3 إعجابات
