Quite often, and decently fast I have to say, when someone reports bug or issue somebody from team tells this PR fixes it. And right after that anxious user makes rebuild or update, returns and cries for help because that fix didn’t change anything. Same poor team member replies that PR isn’t merg…

I’m afraid the answer is: “it depends”. At a minimum, we need to wait for the automated checks to run (about 20 mins), and we need at least one other person on the Team to review/approve the PR. That can take anywhere from minutes to days, depending on availability/priority. If it’s a more complex …

Of course that badge :man_facepalming: Yeah — it depends is a good answer. And expected one too.

¿Cuándo se fusionan los PR?

Desarrollador

Jagster (Jakke Flemming) 8 Julio, 2022 08:42 3

Por supuesto, esa insignia

Sí, depende es una buena respuesta. Y una esperada también.

Tema		Respuestas	Vistas
Questions about GitHub bug fix commits and tests-passed Development	4	1252	20 Diciembre 2016
What's the process to get a theme-component PR reviewed? Development easy-responsive-footer	5	511	29 Febrero 2024
What is the turn around time for pull request? Development rest-api	2	307	24 Agosto 2023
Recommended approach for production discourse using PR (not merged) Support	15	371	21 Febrero 2025
Cannot merge users - process never finishes Support	1	120	10 Diciembre 2024

¿Cuándo se fusionan los PR?

Temas relacionados