"Which topic do you want to reply to" popup gets confused

Bug
1

image
image.png1144×670 64.7 KB

Steps I took to make this happen:

  1. Start replying to a topic.
  2. Go home.
  3. Switch to the “categories” view.
  4. Load a category.
  5. Load a topic in that category.
  6. Use the back button twice to return to “categories”.
  7. Hit the “reply” button.

It looks like going into a different topic sets a flag indicating that that might be the topic to reply to, but this flag isn’t unset when leaving the topic.

3 לייקים
2

And both of the topics were in different categories?

3

Yes, both topics were in different categories.

לייק 1
4

OK easy repro,

  • start typing reply here.
  • Hit home
  • Visit different topic
  • Hit back
  • Hit reply
3 לייקים
6

Could this be an easy starter bugfix @sam?

7

Unfortunately not, this logic is in a fairly complex spot with high chance of regressions.

I can have a look when I free up.

9

Well… better late than never… this is now fixed :racing_car:

https://github.com/discourse/discourse/commit/9f1e8d4f58243ef8e18e32fc82f3e0bd74d833f2

4 לייקים
10

This topic was automatically closed after 4 days. New replies are no longer allowed.