Why instagram link onebox like this?

Pad_Pors · 1월 8, 2020, 11:42오전

why does this instagram link onebox like this?

https://www.instagram.com/p/B3jG277hve9/

it also links to nowhere if I don’t use hyperlinked text (you can click on the one-boxed link above)!

the link:
https://www.instagram.com/p/B3jG277hve9/

codinghorror · 1월 9, 2020, 6:34오전

My guess is it is a private account?

rishabh · 1월 9, 2020, 7:00오전

Nope, that’s not a private account. Here’s another example from a fully public post:

https://www.instagram.com/p/B6gUJwDl-lQ/

Wow, I posted https://www.instagram.com/p/B6gUJwDl-lQ/ but the onebox redirects to this topic itself…

(edit my post to repro this in the composer)

codinghorror · 1월 9, 2020, 7:05오전

What’s different about this photo versus others?

Hector · 1월 10, 2020, 1:22오후

It seems that some Instagram pages have a canonical link with a different url that requires login. The code in the onebox library prefers the canonical url.

github.com/discourse/onebox

lib/onebox/helpers.rb

main


      
          end
          
          def self.fetch_html_doc(url, headers = nil, body_cacher = nil)
            response = (fetch_response(url, headers: headers, body_cacher: body_cacher) rescue nil)
            Nokogiri::HTML(response)
          end
          
          def self.fetch_response(location, redirect_limit: 5, domain: nil, headers: nil, body_cacher: nil)
            redirect_limit = Onebox.options.redirect_limit if redirect_limit > Onebox.options.redirect_limit
          
            raise Net::HTTPError.new('HTTP redirect too deep', location) if redirect_limit == 0
          
            uri = Addressable::URI.parse(location)
            uri = Addressable::URI.join(domain, uri) if !uri.host
          
            use_body_cacher = body_cacher && body_cacher.respond_to?('fetch_cached_response_body')

For example, these are the canonical urls of the instagrams in this topic:

https://www.instagram.com/shaparakgroup.ir/p/B3jG277hve9/caption/backhand_index_pointing_right-chp-shprkh-ok_hand-black_small_square-khrt-wyzyt-hy-brsh-khs

https://www.instagram.com/dogsofinstagram/p/B6gUJwDl-lQ/caption/happy-holidays-writes-konaandcamper-misslolathegoldendoodle-camera_with_flash-by-sh

WaitroseCarpark · 1월 13, 2020, 7:12오전

I’m getting this issue as well. Upgrading my installation now to see if it fixes.

codinghorror · 1월 13, 2020, 9:15오전

@techAPJ can you fix this please? Basically we have to ignore canonical metadata for Instagram now..

techAPJ · 1월 13, 2020, 3:01오후

Done via:

https://github.com/discourse/onebox/commit/0d88354b4b85c572a7f2431bd01d849392625b5c

Example link:

https://www.instagram.com/p/B7Cz042qSxv/

jomaxro · 5월 21, 2020, 6:07오후

Looks like we’ve regressed here, or Instagram changed something again. We’re back to just showing “Login • Instagram”. cc @techAPJ

cvx · 5월 22, 2020, 12:35오전

Weird, that image on Instagram doesn’t have any og: meta tags anymore. Couldn’t find any other that would have them missing…

techAPJ · 5월 22, 2020, 8:20오전

The weird thing is Instagram onebox is working okay for me locally (on latest Discourse version). And I do see OpenGraph (og) tags in incognito mode.

Reproducing this issue locally will be tricky.. investigating more.

codinghorror · 5월 22, 2020, 11:18오후

Is it specific to that one image?

techAPJ · 5월 22, 2020, 11:51오후

No, I tried multiple images from multiple accounts and all were oneboxing fine locally.

Here’s an image from an hour ago on NatGeo oneboxing fine locally.

Might be geographical issue?

FWIW, Instagram oneboxing is failing on discourse.codinghorror.com as well, so this issue is not specific to meta.

Falco · 5월 23, 2020, 4:16오전

Maybe the user agent changes the response?

znedw · 5월 26, 2020, 4:55오전

https://www.instagram.com/p/CAojxzfjO0y/

this is broken on our forum as well

techAPJ · 5월 26, 2020, 5:11오전

I don’t think so. We use same user agent for all the requests made from Discourse codebase as per:

github.com/discourse/discourse

lib/final_destination.rb

edbc35659


      
            end
          
            @status = :ready
            @http_verb = @force_get_hosts.any? { |host| hostname_matches?(host) } ? :get : :head
            @cookie = nil
            @limited_ips = []
            @verbose = @opts[:verbose] || false
            @timeout = @opts[:timeout] || nil
            @preserve_fragment_url = @preserve_fragment_url_hosts.any? { |host| hostname_matches?(host) }
            @validate_uri = @opts.fetch(:validate_uri) { true }
            @user_agent = @force_custom_user_agent_hosts.any? { |host| hostname_matches?(host) } ? Onebox.options.user_agent : "Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36"
          end
          
          def self.connection_timeout
            20
          end
          
          def timeout
            @timeout || FinalDestination.connection_timeout
          end

Richie · 5월 26, 2020, 10:28오전

Same issue on ours now here in the UK too.

techAPJ · 5월 26, 2020, 10:34오전

I am updating Instagram onebox to use official oEmbed endpoints. I have this change working locally and expect to push a fix later today. Hopefully the Instagram oEmbed endpoints will not have geographical restrictions.

글		댓글	조회수
Instagram oneboxing Feature	110	12118	11월 26, 2020
Instagram onebox is not working Support	8	1454	11월 24, 2020
Facebook / Instagram oneboxes will probably fail from today Oct 24 2020 Support	14	2365	11월 23, 2020
Instagram oneboxes not working on meta? Site feedback embedding	3	836	7월 16, 2022
Incorrect or failing oneboxes for links to other discourse instances Bug	16	2343	8월 17, 2017

Why instagram link onebox like this?

Related topics