Thanks for your work on allowing different S3 backends! I am using minio and it is working great…
The only slight issue I have is that the UpdatePostUploadsSecureStatus job is failing because Minio does not support ACLs:
opened 02:26PM - 06 Sep 19 UTC
closed 03:58AM - 07 Sep 19 UTC
community
wont fix
triage
I've read through a few github issues and the minio docs, and it seems you don't… support setting object ACLs (nor intend to). You claim to be an S3 compatible server, but if you aren't supporting this feature, that's not really true IMO. Regardless of whether or not AWS recommends using ACLs, they nevertheless still support them and it is a good enough solution for plenty of people's usage. Not supporting object ACLs prevents Minio from being a drop-in replacement for S3. Someone who wanted to switch to Minio would have to start adding prefixes to everything which could break their existing naming scheme for objects. This is a problem if they wanted to be able to support objects stored in S3 and in Minio, and if they already had pre-existing data in S3 which used Object ACLs. This is the situation I personally am in.
I really think you should reconsider this.
Is there a way I can disable this job from running?
Falco
18 فبراير 2023، 4:51م
2
Have you enabled SiteSetting.secure_uploads ?
Nope, I have not.
EDIT: I did import some emails which had images embedded I’m them. I am reading the Secure uploads in emails docs, is that saying that all uploads from emails will be “secure”?
إعجاب واحد (1)
Falco
19 فبراير 2023، 1:35م
4
Why do we schedule this job for every upload on every post even when the setting is disabled @martin ?
3 إعجابات
martin
19 فبراير 2023، 11:38م
5
Good question – this is called in two places. PostCreator:
And PostRevisor:
However as you can see I neglected to do the SiteSetting.secure_uploads? check in the latter…I will make a PR to fix this and just move the check to post.update_uploads_secure_status.
Edit: PR is here, hopefully should merge today FIX: Do not enqueue UpdatePostUploadsSecureStatus unnecessarily by martin-brennan · Pull Request #20366 · discourse/discourse · GitHub
4 إعجابات
