Why run UpdatePostUploadsSecureStatus even when secure uploads is disabled?

saulshanabrook · February 18, 2023, 4:45pm

Thanks for your work on allowing different S3 backends! I am using minio and it is working great…

The only slight issue I have is that the UpdatePostUploadsSecureStatus job is failing because Minio does not support ACLs:

https://github.com/minio/minio/issues/8195

Is there a way I can disable this job from running?

Falco · February 18, 2023, 4:51pm

Have you enabled SiteSetting.secure_uploads ?

saulshanabrook · February 19, 2023, 1:08pm

Nope, I have not.

EDIT: I did import some emails which had images embedded I’m them. I am reading the Secure uploads in emails docs, is that saying that all uploads from emails will be “secure”?

Falco · February 19, 2023, 1:35pm

Why do we schedule this job for every upload on every post even when the setting is disabled @martin ?

martin · February 19, 2023, 11:38pm

Good question – this is called in two places. PostCreator:

github.com/discourse/discourse

lib/post_creator.rb

3c57db5c6


      
          def update_uploads_secure_status
            @post.update_uploads_secure_status(source: "post creator") if SiteSetting.secure_uploads?
          end

And PostRevisor:

github.com/discourse/discourse

lib/post_revisor.rb

3c57db5c6


      
          # This must be done before post_process_post, because that uses
          # post upload security status to cook URLs.
          @post.update_uploads_secure_status(source: "post revisor")

However as you can see I neglected to do the SiteSetting.secure_uploads? check in the latter…I will make a PR to fix this and just move the check to post.update_uploads_secure_status.

Edit: PR is here, hopefully should merge today FIX: Do not enqueue UpdatePostUploadsSecureStatus unnecessarily by martin-brennan · Pull Request #20366 · discourse/discourse · GitHub

Topic		Replies	Views
Minio: A header you provided implies S3 functionality that is not implemented Support	19	10255	April 5, 2021
Can not edit topics with picture with S3 backend Bug	10	1201	July 9, 2021
Secure Uploads Announcements secure-uploads	43	17334	July 24, 2025
Upload objects to private S3 is not working Support s3	5	2651	June 14, 2022
Image upload error: The bucket does not allow ACL's Support s3	5	1781	June 10, 2022

Why run UpdatePostUploadsSecureStatus even when secure uploads is disabled?

Related topics