Why run UpdatePostUploadsSecureStatus even when secure uploads is disabled?

Product Support

AI-generated summary

The discussion revolves around the UpdatePostUploadsSecureStatus job failing when using MinIO with secure uploads disabled. saulshanabrook reports the job fails due to MinIO’s lack of ACL support, despite not having SiteSetting.secure_uploads enabled. Falco questions why the job runs even when secure uploads are disabled, prompting martin to acknowledge a missing check in the PostRevisor and confirm a fix is being implemented via a PR here.

1

Thanks for your work on allowing different S3 backends! I am using minio and it is working great…

The only slight issue I have is that the UpdatePostUploadsSecureStatus job is failing because Minio does not support ACLs:

https://github.com/minio/minio/issues/8195

Is there a way I can disable this job from running?

2

Have you enabled SiteSetting.secure_uploads ?

3

Nope, I have not.

Screenshot 2023-02-19 at 8.08.47 AM
Screenshot 2023-02-19 at 8.08.47 AM1272×340 48.7 KB

EDIT: I did import some emails which had images embedded I’m them. I am reading the Secure uploads in emails docs, is that saying that all uploads from emails will be “secure”?

4

Why do we schedule this job for every upload on every post even when the setting is disabled @martin ?

5

Good question – this is called in two places. PostCreator:

And PostRevisor:

However as you can see I neglected to do the SiteSetting.secure_uploads? check in the latter…I will make a PR to fix this and just move the check to post.update_uploads_secure_status.

Edit: PR is here, hopefully should merge today FIX: Do not enqueue UpdatePostUploadsSecureStatus unnecessarily by martin-brennan · Pull Request #20366 · discourse/discourse · GitHub