Workflow modal must be closed in every Discourse tab

Contribute Bug
1

Priority/Severity:

Medium

Platform:

Operating System

Windows 11

Browser

Google Chrome 151.0.7922.138

Discourse

763655f6faf47b088afee1a59e2d97cec5886c97

Description:

The new “Workflows” core plugin has a “Modal” step type. This step displays a modal to the target user.

If the target user has multiple browser tabs/windows open on the forum’s pages, the modal will appear persistently in every tab.

:bug: The user will need to close the modal in every single tab.

:bug: If the user resolves the redundant modal instances by clicking a button, a confusing error message will appear.

Reproducible steps:

  1. Log into a Discourse forum account with admin permissions, on a site that has the new “Workflows” plugin enabled.
  2. Open multiple forum pages in separate tabs in your web browser.
  3. Open the “Workflows” page (/admin/plugins/discourse-workflows/workflows).
  4. Click the “+ New workflow” button.
    A new workflow will be created.
  5. Click the + button.
    The “Add step” panel will open.
  6. Select Triggers > Manual trigger from the panel.
    A “Manual trigger” step will be added to the workflow.
  7. Click the + button.
    The “Add step” panel will open.
  8. Select Human Review > Modal from the panel.
    A “Modal” step will be added to the workflow.
  9. Double click on the newly added “Modal” step.
    The configuration dialog for the step will open.
  10. Type any text into the “Title” field in the dialog.
  11. Click the “Add button” button in the dialog.
    ⓘ This is not required to reproduce the fault, but it does result in an even more severe impact.
  12. Type any text into the “Label” field for the button.
  13. Type any value into the “Value” field for the button.
  14. Click the X icon at the top right hand corner of the dialog.
    The dialog will close.
  15. Connect the output of the “Manual trigger” step to the input of the “Modal” step.
  16. Hover the mouse pointer over the “Manual trigger” step.
    A ▷ button will appear over the step.
  17. Click the ▷ button (“Run manually with the sample pinned data”)
    :slightly_smiling_face: The dialog appears in the current tab.
  18. Click the button in the dialog.
    :slightly_smiling_face: The dialog closes.
  19. Switch to one of the other forum page browser tabs you opened at step 2 in these instructions.
    :bug: The dialog is present in the tab, even though you already closed it in the previous tab.
  20. Click the button in the dialog.
    :bug: An error dialog appears:

    An error occurred: The requested URL or resource could not be found.