Wrong custom date and time in silenced and suspended warnings

[Don]

Hello,

I noticed the suspend and silenced warnings and emails contains wrong date. Sorry if I missed something about this.

Repro

1. Set up a (custom date and time) on suspend modal. I seted up a week suspend.
   
   
2. Set a reason and a custom email message
   
   
3. Click the suspend button

---

In the email it says until May 12, 2022 at 22:00

On the user card it shows until May 13, 2022 at 00:00

Same on admin page.

I think on the user card and admin the time should be 9:32 and in the email the date and time both wrong.

Thanks

[JammyDodger]

I’ve been having a little play with this and there does seem to be some discrepancy between times/dates input and time/dates displayed.

For a suspension of 1 day (the pre-entered default):

---

And for a custom suspension of 1 week:

In both cases the email was an hour off, and any suspension longer than a day rounded out the time to midnight, and also knocked a day off the date in the email version.

Edit: Making sure I got all the right screenshots along the way clouded my thinking.

It’s because it’s knocking an hour off 00:00 which causes it to be a day early. So, it’s more about the lost hour between input and email. And @Don lost two.

[andrei (Andrei Prigorshnev)]

I can reproduce all problems. I’ll take a look at it.

[andrei (Andrei Prigorshnev)]

This fixes date in emails both when silencing and suspending users. Dates will be converted to user’s timezone:

https://github.com/discourse/discourse/pull/16918

Next we need to fix the rounding issue. I am looking at that.

[andrei (Andrei Prigorshnev)]

The rounding bug was just fixed by @j.jaffeux in

https://github.com/discourse/discourse/pull/16937