Falscher Grund angezeigt, warum Moderator-Benutzer nicht gelöscht werden kann

Fehler
1

In FIX: Correct user deletion wording by hlashbrooke · Pull Request #34680 · discourse/discourse · GitHub “and moderators” was removed from the note explaining why a user can’t be deleted:

delete_forbidden_because_staff: “Admins and moderators can’t be deleted.”

I understand that this is helpful because moderators can be deleted. But I have the impression that something was overlooked in this adjustment, which confused me today.
My user is a moderator, but not an admin, and still the note said “Admins can’t be deleted”.

Screenshot_20251017_163402_Firefox
Screenshot_20251017_163402_Firefox1134×351 39.6 KB

…
Screenshot_20251017_163336_Firefox
Screenshot_20251017_163336_Firefox1107×385 42.1 KB

After checking the code, I think I found why this happens: If a user cannot be deleted, there are two possible reasons:

  1. The user is an admin.
  2. The user has posts older than configured.

The real reason why I couldn’t delete my moderator user was [2], but the reason shown is [1], because while moderators were removed from the text of the warning, the code still checked for staff instead of admin.

3 „Gefällt mir“
2

yea I can repro this on my hosted test site as well. as soon as I delete the posts for my test moderator account, the “admins can’t be deleted” message is replaced by the delete button. thanks for reporting Moin :slight_smile:

1 „Gefällt mir“
4

To clarify further.. a user who is not moderator can’t be deleted and the reason shown is below. The bug is that the wrong reason is shown when the user is a moderator.

Users can’t be deleted if they have posts. Delete all posts before trying to delete a user. (Posts older than 365 days old can’t be deleted.)

Screenshot 2025-10-17 at 11.11.11 AM
Screenshot 2025-10-17 at 11.11.11 AM979×155 10.8 KB

5

Admins see the wrong reason too. It’s not about who looks at the user’s admin page, but what status the user has that you are looking at.

6

Yeah that’s what I meant but got the sentence structure wrong! :rofl: I think I fixed it now.

All of this said.. I wonder why it is possible to delete moderators. I think it makes sense to demote users before deleting them and have always done that, and not questioned the UI.

7

Thank you. I was concerned that your clarification would lead to misunderstandings, even though I thought the title described the problem quite well.

1 „Gefällt mir“