Thanks for taking the time to dig into the code! That looks like a bug to me - we check the fullName, then replace it with firstName lastName. Line 133 in that snippet is totally useless 
I’ve been working on the SAML plugin this week anyway, so here’s a fix:
https://github.com/discourse/discourse-saml/pull/42
Once that’s merged, the fullName will be correctly prioritised