בדיקת קוד אוטומטית ופורמט לפני ההתחייבויות

[Discourse]

Discourse uses lefthook for git hooks, and bin/lint as the main CLI entry point for running the same checks manually.

If you are working in a local clone, install the hooks once:

pnpm install
pnpm lefthook install

After that, staged files will be checked automatically on git commit.

The main command: bin/lint

Use bin/lint when you want to run the repo’s configured linters yourself instead of waiting for the pre-commit hook.

Common examples:

bin/lint
bin/lint path/to/file.rb path/to/file.gjs
bin/lint --recent
bin/lint --staged
bin/lint --unstaged
bin/lint --wip
bin/lint --fix path/to/file.rb
bin/lint --fix --recent
bin/lint --fix

What each mode does

• bin/lint: lint all supported files in the repository
• bin/lint path/to/file ...: lint only the given files
• bin/lint --recent: lint files changed in the last 50 commits, plus untracked files
• bin/lint --staged: lint only staged files
• bin/lint --unstaged: lint only unstaged files
• bin/lint --wip: lint staged files, unstaged files, and files changed since main
• bin/lint --fix ...: run the auto-fixers for the selected files
• bin/lint --fix: run all available auto-fixers across the repository
• bin/lint --verbose: print the underlying lefthook commands

When you pass explicit files, bin/lint filters them to supported lintable file types before invoking lefthook.

Markdown documentation files are not currently part of bin/lint, so running bin/lint path/to/doc.md will report that there are no matching files to lint.

What gets linted

The exact configuration lives in lefthook.yml. At the time of writing, bin/lint covers:

Ruby

• **/*.{rb,rake,thor}
• Ruby scripts under bin/**/*
• Gemfile

Checks:

• rubocop
• syntax_tree (stree check)

JavaScript, GJS, CSS, and SCSS formatting

• app/assets/stylesheets/**/*.{css,scss}
• frontend/**/*.{js,gjs,scss,css,cjs,mjs}
• matching plugin and theme asset files

Checks:

• prettier/pprettier

JavaScript and GJS linting

• frontend/**/*.{js,gjs}
• matching plugin and theme JS files

Checks:

• eslint

GJS template linting

• frontend/**/*.gjs
• matching plugin and theme .gjs files

Checks:

• ember-template-lint

SCSS linting

• app/assets/stylesheets/**/*.scss
• matching plugin and theme SCSS files

Checks:

• stylelint

YAML and locale checks

• **/*.{yaml,yml} except config/database.yml
• **/{client,server}.en.yml

Checks:

• yaml-lint
• script/i18n_lint.rb

Type checking

When you run bin/lint with no file arguments, the full-repo lint also runs:

• pnpm lint:types

This is the Glint/TypeScript-style check for Discourse’s JavaScript type information.

bin/lint path/to/file and the pre-commit hook do not run the full type check. Use plain bin/lint when you want the complete repo-wide lint pass.

What can be auto-fixed

bin/lint --fix can automatically fix a lot of issues, but not all of them.

Auto-fix is configured for:

• prettier --write
• eslint --fix
• ember-template-lint --fix
• stylelint --fix
• rubocop -A
• syntax_tree (stree write)

In practice, that means --fix can reformat and rewrite:

• Ruby
• JavaScript / GJS
• CSS / SCSS

These checks are not auto-fixed by bin/lint --fix:

• YAML syntax validation
• i18n linting for client.en.yml / server.en.yml
• Glint/type checking

Relationship to git hooks

The pre-commit hook uses the same lefthook configuration as bin/lint, but it runs only against staged files.

That means:

• a commit can fail because staged files do not pass linting
• bin/lint --staged is the closest manual equivalent to the pre-commit hook
• bin/lint --fix --staged is a good way to repair exactly what you are about to commit

Practical workflow

For day-to-day development, these are the most useful commands:

# Before committing a couple of changed files
bin/lint --fix path/to/file1.rb path/to/file2.gjs

# Check exactly what the pre-commit hook will check
bin/lint --staged

# Clean up all current in-progress work
bin/lint --fix --wip

# Run the full repo lint suite, including type checks
bin/lint

---

This document is version controlled - suggest changes on github.