"Show more" link for uploading an image from the web

AI-generated summary

The discussion revolves around the “Show more” link for uploading an image from the web. nexo initially asks about the difference between two input fields and why the “Show more” link remains after clicking it. fdsa explains that the first field is for the image link, and the second is for a redirect link when the image is clicked.

fdsa and simon agree that the “Show more” link staying after being clicked is a UI mistake and should be changed to “Show less” after expansion. However, zogstrip and codinghorror suggest removing the feature altogether, as it can generate broken markdown. zogstrip requests @dan to add the removal to his list, which dan subsequently does by submitting a PR to remove the feature.

Two questions about this:

  1. What is the main difference between the two fields?
  2. And why does it still say show more after you already clicked it?
3 Likes

The first field is where you put a link to the actual image. The second field is where you put a website to redirect someone to when they click on it.
For example, the following images are the same, but clicking on them will take you to different sites.

Probably a simple mistake in the UI.

5 Likes

Yes, that link should say something like “Show less” after the modal window has been expanded.

5 Likes

I’m not even sure we even need that “feature”?

For example, if you upload a txt file from the web and add a link, then you generate this broken markdown

[![](https://www.discourse.org/robots.txt)](https://www.discourse.org/)

We could only show the show more toggle when we detect the user has pasted a link to an image (based on the extension) but that’s not 100% bullet proof.

7 Likes

Probably we should remove it?

1 Like

@dan can you add to your list to remove this show more “feature”?

4 Likes

Submitted a PR to remove this:

https://github.com/discourse/discourse/pull/8470

5 Likes