Over zealous hiding of plugin outlet?

Development

AI-generated summary

The discussion revolves around the Over zealous hiding of plugin outlet in Discourse. merefield points out that the plugin outlet for user-card-location-and-website is hidden if a user hasn’t entered a vanilla location or website, which affects the Discourse-Locations plugin.

pusaraj suggests using the user-card-before-badges plugin outlet instead, which is always shown. However, merefield initially fears formatting impact and later decides to override a computed property boolean switch to resolve the issue.

After implementing the solution, merefield confirms that the problem is fixed, and pmusaraj acknowledges that no worries were caused.

1

Team,

The plugin outlet: user-card-location-and website is hidden

hasLocaleOrWebsite is false if user hasn’t entered a vanilla location or website, which hides the outlet (you can see this on the plugin outlets theme component clearly).

This seems overly zealous?

The problem for plugin Discourse-Locations, is that none of these should be necessary for you to see your map location which is attached to this plugin location (Hey, it’s another form of location!).

https://github.com/discourse/discourse/commit/bb4e965a6694710069cb11b509ebbd1c32847a5c

I wonder if you could take a look?

Thanks!!

Rob

2

Can the locations plugin use the user-card-before-badges plugin outlet instead? Looks like that plugin outlet is always shown.

3

I’ll test and revert. I feared formatting impact.

4

It’s a little more involved, because the current code is doing all kinds of clever rearrangment of the elements.

The simplest approach is probably to override this Computed Property boolean switch with my own calc and everything should be dandy! :slight_smile:

Update: all sorted, sorry to bother you!

5

All good, no worries.