Over zealous hiding of plugin outlet?

merefield · June 3, 2020, 4:47pm

Team,

The plugin outlet: user-card-location-and website is hidden

https://github.com/discourse/discourse/blob/207b72ade18c07a5e131217b76722d6e9b926984/app/assets/javascripts/discourse/app/templates/components/user-card-contents.hbs

hasLocaleOrWebsite is false if user hasn’t entered a vanilla location or website, which hides the outlet (you can see this on the plugin outlets theme component clearly).

This seems overly zealous?

The problem for plugin Discourse-Locations, is that none of these should be necessary for you to see your map location which is attached to this plugin location (Hey, it’s another form of location!).

https://github.com/discourse/discourse/commit/bb4e965a6694710069cb11b509ebbd1c32847a5c

I wonder if you could take a look?

Thanks!!

Rob

pmusaraj · June 3, 2020, 4:53pm

Can the locations plugin use the user-card-before-badges plugin outlet instead? Looks like that plugin outlet is always shown.

github.com

discourse/discourse/blob/207b72ade18c07a5e131217b76722d6e9b926984/app/assets/javascripts/discourse/app/templates/components/user-card-contents.hbs#L242


      
                    <div class="public-user-field {{uf.field.dasherized_name}}">
                      <span class="user-field-name">{{uf.field.name}}:</span>
                      <span class="user-field-value">{{uf.value}}</span>
                    </div>
                  {{/if}}
                {{/each}}
              </div>
            </div>
          {{/if}}
          
          {{plugin-outlet name="user-card-before-badges" args=(hash user=this.user)}}
          
          {{#if this.showBadges}}
            <div class="card-row">
              {{#if this.user.featured_user_badges}}
                <div class="badge-section">
                  {{#each this.user.featured_user_badges as |ub|}}
                    {{user-badge badge=ub.badge user=this.user}}
                  {{/each}}
                  {{#if this.showMoreBadges}}
                    <span class='more-user-badges'>

merefield · June 3, 2020, 4:54pm

I’ll test and revert. I feared formatting impact.

merefield · June 3, 2020, 5:09pm

It’s a little more involved, because the current code is doing all kinds of clever rearrangment of the elements.

The simplest approach is probably to override this Computed Property boolean switch with my own calc and everything should be dandy!

Update: all sorted, sorry to bother you!

pmusaraj · June 3, 2020, 6:59pm

All good, no worries.

Topic		Replies	Views
New user profile and card plugin outlets for location and website area Feature	1	1189	October 25, 2016
TC/Plugin architecture: should we have more control over classes? Dev	5	213	July 12, 2024
api.decorateWidget - how can I find the template's names? Support	5	2143	January 10, 2021
Plugin outlet locations theme component Theme component	28	8937	July 2, 2024
Recent Discourse update broke plugin outlet in strange way Dev	4	468	June 8, 2024

Over zealous hiding of plugin outlet?

Related Topics