"Code review inschakelen" instelling voorkomt niet dat de Code Review plugin communiceert met GitHub

AI-generated summary

A bug has been reported regarding the enable Discourse code review setting in the Code Review plugin. Even when this setting is turned off, the plugin still creates new topics in Discourse for comments from GitHub, which is unintended behavior. meglio highlighted the issue, noting that the plugin continues to interact with GitHub despite being disabled. justin suggested opening a dedicated bug report, and markvanlan provided a pull request (PR #39) that addresses the issue by ignoring incoming webhook events when the plugin is disabled, ensuring no interactions occur.

Continuing the discussion from Discourse Code Review:

This topic is to report a bug. I currently cannot turn off all Code Review plugin interactions with GitHub by unchecking the enable Discourse code review checkbox.

It is important to note that all other settings are configured, i.e. access tokens etc.

4 likes

Here is a PR that simply ignores all incoming webhook events if the plugin is disabled.
https://github.com/discourse/discourse-code-review/pull/39/files

4 likes