"Code review inschakelen" instelling voorkomt niet dat de Code Review plugin communiceert met GitHub

Continuing the discussion from Discourse Code Review:

This topic is to report a bug. I currently cannot turn off all Code Review plugin interactions with GitHub by unchecking the enable Discourse code review checkbox.

It is important to note that all other settings are configured, i.e. access tokens etc.

4 likes

Here is a PR that simply ignores all incoming webhook events if the plugin is disabled.
https://github.com/discourse/discourse-code-review/pull/39/files

4 likes