为标签添加一个 data-tag-group 属性

tobiaseigen · 2025年十月20日 19:47

只是想分享一下，这个功能已经有人着手开发了，但后来发现这是一个很大的改动，所以关闭了。这是一个很棒的想法，但不幸的是，团队近期不太可能采纳它。

github.com/discourse/discourse

FEATURE: Add data-tag-groups attribute to tags

main ← add-tag-groups-for-tag

opened 07:55AM - 17 Jul 24 UTC

Lhcfl

+471 -107

## Overview This commit adds the `data-tag-groups` attribute to tags, making …it easier to use CSS selectors to batch select tags belonging to certain tag groups. An example: ```html <a href="/tag/hidden" data-tag-name="hidden" data-tag-groups="Hidden Tag Group, non-hidden tags" class="discourse-tag box">hidden</a> ``` Related meta topic: https://meta.discourse.org/t/add-a-data-tag-group-attribute-for-tags/234410 ## Detailed changes Add data-groups to these... - [ ] Tags for topics - [x] The effect has been shown - [ ] Tests already written - [ ] Confirms that there are no performance issues - [ ] TagChooser at the top of TopicList - [x] The effect has been shown - [x] Tests already written - [ ] Confirms that there are no performance issues - [ ] Tags on the sidebar - [x] The effect has been shown - [ ] Tests already written - [ ] Confirms that there are no performance issues - [ ] Tags on the `/tags` page - [x] The effect has been shown - [ ] Tests already written - [ ] Confirms that there are no performance issues - [ ] Search bar tags - [x] The effect has been shown - [ ] Tests already written - [ ] Confirms that there are no performance issues - [ ] Composer tags chooser - [x] The effect has been shown - [ ] Tests already written - [ ] Confirms that there are no performance issues - [ ] ~~Tags in the post body~~ Maybe next PR ## DEV Improvements Partially rewrote `defaultRenderTag` for better scalability and clarity: The new `defaultRenderTag` reserves an interface for theme components to avoid the need for components to completely rewrite `defaultRenderTag` to provide custom tag renderer. For example, you can now replace the tagRenderer like this: ```javascript api.replaceTagRenderer((tag, params) => { return defaultRenderTag(tag, params, { extraClass: "custom-tag-class", contentFn(old) { return `${iconHTML("tag")}${old}`; }, }); }); ``` This has a significant benefit for discourse tag icons. Since the [old way of code](https://github.com/discourse/discourse-tag-icons/blob/main/javascripts/discourse/initializers/tag-icons.js#L9-L84) the changes made by this PR will be completely overwritten by discourse tag icons, and the theme component must be updated accordingly. After applying the new interface, it can automatically synchronize changes with the `defaultRendererTag` in core.

話題		回覆	觀看
PAID - Request - add CSS class containing tag group Marketplace	5	349	2024年六月23日
Add CSS class containing tag group Feature tag-groups	6	1601	2021年一月30日
Tag Icons working with tag groups Feature tag-icons	7	358	2025年十月2日
Tag Icons Theme component official , tag-icons	91	20629	2026年三月3日
How can I assign a color code to a Tag Group (so all tags in the group share it)? Feature tags , tag-groups	1	147	2025年十月1日

为标签添加一个 data-tag-group 属性

相關主題