Reactions plugin: 500 Internal Server Error

Contribute Bug

AI-generated summary

A user, OrkoGrayskull, reported a 500 Internal Server Error when accessing the “activity → reactions” page on their Discourse forum. The error occurred when loading /discourse-reactions/posts/reactions.json.

RGJ asked OrkoGrayskull to check the /logs for details about the error. OrkoGrayskull found a NoMethodError in group_post_serializer.rb. However, the rest of the errors were just warnings unrelated to the 500 error.

Don was able to reproduce the issue and found that it happened when a user had a reaction on a post in a deleted topic. Don provided a step-by-step reproduction of the issue, which involved deleting a topic’s OP while leaving a post with reactions intact.

JammyDodger was unable to replicate the issue and asked if there were any special settings or reactions involved.

joffreyjaffeux thanked the users for reporting the issue and mentioned that a fix was under review. The fix was later merged in a pull request: https://github.com/discourse/discourse-reactions/pull/191.

1

Good morning community,

when someone clicks on their profile and there clicks activity → reactions, this throws a HTTP 500 Error:

Server error
while loading /discourse-reactions/posts/reactions.json
Error code: 500 Internal Server Error

I am using a Discourse Standard installation (2.9.0.beta10/ c752d68737 ) with the following plugins:

There seems to be a bug.

2

Cannot repro, can you please check /logs and post any details about the error here?

3

I can only find one error in /logs:

NoMethodError (undefined method title' for nil:NilClass) app/serializers/group_post_serializer.rb:21:in title’ (eval):7:in _fast_attributes' lib/freedom_patches/ams_include_without_root.rb:57:in i

app/serializers/group_post_serializer.rb:21:in `title'
(eval):7:in `_fast_attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:468:in `rescue in attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:455:in `attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:480:in `_serializable_hash'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:359:in `serializable_hash'
active_model_serializers (0.8.4) lib/active_model/serializer/associations.rb:200:in `serialize'
lib/freedom_patches/ams_include_without_root.rb:57:in `include!'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:368:in `block in include_associations!'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:367:in `each_key'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:367:in `include_associations!'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:362:in `serializable_hash'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:89:in `block in _serializable_array'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:79:in `map'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:79:in `_serializable_array'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:73:in `serializable_array'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:53:in `as_json'
app/controllers/application_controller.rb:519:in `serialize_data'
app/controllers/application_controller.rb:530:in `render_serialized'
plugins/discourse-reactions/app/controllers/discourse_reactions/custom_reactions_controller.rb:54:in `reactions_given'
actionpack (7.0.3.1) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
actionpack (7.0.3.1) lib/abstract_controller/base.rb:215:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/rendering.rb:53:in `process_action'
actionpack (7.0.3.1) lib/abstract_controller/callbacks.rb:234:in `block in process_action'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:118:in `block in run_callbacks'
app/controllers/application_controller.rb:413:in `block in with_resolved_locale'
i18n (1.12.0) lib/i18n.rb:322:in `with_locale'
app/controllers/application_controller.rb:413:in `with_resolved_locale'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:127:in `block in run_callbacks'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:138:in `run_callbacks'
actionpack (7.0.3.1) lib/abstract_controller/callbacks.rb:233:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/rescue.rb:22:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/instrumentation.rb:67:in `block in process_action'
activesupport (7.0.3.1) lib/active_support/notifications.rb:206:in `block in instrument'
activesupport (7.0.3.1) lib/active_support/notifications/instrumenter.rb:24:in `instrument'
activesupport (7.0.3.1) lib/active_support/notifications.rb:206:in `instrument'
actionpack (7.0.3.1) lib/action_controller/metal/instrumentation.rb:66:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/params_wrapper.rb:259:in `process_action'
activerecord (7.0.3.1) lib/active_record/railties/controller_runtime.rb:27:in `process_action'
actionpack (7.0.3.1) lib/abstract_controller/base.rb:151:in `process'
actionview (7.0.3.1) lib/action_view/rendering.rb:39:in `process'
rack-mini-profiler (3.0.0) lib/mini_profiler/profiling_methods.rb:111:in `block in profile_method'


actionpack (7.0.3.1) lib/action_controller/metal.rb:188:in `dispatch'
actionpack (7.0.3.1) lib/action_controller/metal.rb:251:in `dispatch'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:32:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:50:in `block in serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:852:in `call'
railties (7.0.3.1) lib/rails/engine.rb:530:in `call'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `public_send'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `method_missing'
actionpack (7.0.3.1) lib/action_dispatch/routing/mapper.rb:19:in `block in <class:Constraints>'
actionpack (7.0.3.1) lib/action_dispatch/routing/mapper.rb:48:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:50:in `block in serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:852:in `call'
lib/middleware/omniauth_bypass_middleware.rb:71:in `call'
rack (2.2.4) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.2.4) lib/rack/conditional_get.rb:27:in `call'
rack (2.2.4) lib/rack/head.rb:12:in `call'
actionpack (7.0.3.1) lib/action_dispatch/http/permissions_policy.rb:38:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:368:in `call'
rack (2.2.4) lib/rack/session/abstract/id.rb:266:in `context'
rack (2.2.4) lib/rack/session/abstract/id.rb:260:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/cookies.rb:697:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:99:in `run_callbacks'
actionpack (7.0.3.1) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/debug_exceptions.rb:28:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/show_exceptions.rb:26:in `call'
logster (2.11.3) lib/logster/middleware/reporter.rb:43:in `call'
railties (7.0.3.1) lib/rails/rack/logger.rb:40:in `call_app'
railties (7.0.3.1) lib/rails/rack/logger.rb:27:in `call'
config/initializers/100-quiet_logger.rb:23:in `call'
config/initializers/100-silence_logger.rb:31:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/remote_ip.rb:93:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/request_id.rb:26:in `call'
lib/middleware/enforce_hostname.rb:23:in `call'
rack (2.2.4) lib/rack/method_override.rb:24:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/executor.rb:14:in `call'
rack (2.2.4) lib/rack/sendfile.rb:110:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/host_authorization.rb:131:in `call'
rack-mini-profiler (3.0.0) lib/mini_profiler/profiler.rb:393:in `call'


message_bus (4.2.0) lib/message_bus/rack/middleware.rb:60:in `call'
lib/middleware/request_tracker.rb:202:in `call'
railties (7.0.3.1) lib/rails/engine.rb:530:in `call'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `public_send'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `method_missing'
rack (2.2.4) lib/rack/urlmap.rb:74:in `block in call'
rack (2.2.4) lib/rack/urlmap.rb:58:in `each'
rack (2.2.4) lib/rack/urlmap.rb:58:in `call'
unicorn (6.1.0) lib/unicorn/http_server.rb:634:in `process_client'
unicorn (6.1.0) lib/unicorn/http_server.rb:739:in `worker_loop'
unicorn (6.1.0) lib/unicorn/http_server.rb:547:in `spawn_missing_workers'
unicorn (6.1.0) lib/unicorn/http_server.rb:143:in `start'
unicorn (6.1.0) bin/unicorn:128:in `<top (required)>'
vendor/bundle/ruby/2.7.0/bin/unicorn:25:in `load'
vendor/bundle/ruby/2.7.0/bin/unicorn:25:in `<main>'

The rest are just warnings that have nothing to do with the 500 error. In any case, I have not found anything that indicates this.

4

Hello,

I can repro this but don’t know yet what cause it exactly. On my test site, it works on some users but others not.

Console errors:

Screenshot 2022-10-24 at 8.56.28
Screenshot 2022-10-24 at 8.56.28763×120 15.9 KB

1 Like
5

Yeah, true. For some users it works, for others not.

1 Like
6

I can’t replicate this so far. Is there anything special about those users or their reactions? Or any semi-related admin settings that may have been tweaked?

7

Ok finally I think I have a clean repro for this: I think this is happens when the user has reaction in one of the not deleted post in a deleted topic (OP).

Repro:

  1. Add reaction to OP and the second post.

    Screenshot 2022-10-24 at 11.08.05
    Screenshot 2022-10-24 at 11.08.05833×564 31 KB

  2. Check the Test1 user activity/reactions page it works now as expected

    Screenshot 2022-10-24 at 11.09.17
    Screenshot 2022-10-24 at 11.09.171104×577 45.8 KB

  3. Delete only the topic OP with delete topic button so the second post not deleted.

    Screenshot 2022-10-24 at 11.10.39
    Screenshot 2022-10-24 at 11.10.39865×573 32.3 KB

  4. Check the Test1 user activity/reactions page again drop a 500 error because I think the route is broken.

    Screenshot 2022-10-24 at 10.51.52
    Screenshot 2022-10-24 at 10.51.52825×539 14.3 KB

  5. Un-Delete the topic or delete the post too will recover the activity/reactions page.

It also happens with deleted category if the About the … category topic has reactions. I think because the actual post not deleted.

  1. Add a reaction with Test1 user in the Test Subcategory category.

    Screenshot 2022-10-24 at 11.19.24
    Screenshot 2022-10-24 at 11.19.24864×314 21.8 KB

  2. Check the Test1 user activity/reactions page works as expexted

    Screenshot 2022-10-24 at 11.22.30
    Screenshot 2022-10-24 at 11.22.301092×635 42.4 KB

  3. Delete Test Subcategory category.

  4. Check the Test1 user activity/reactions page again will drop a 500 error because the reaction left on the OP and the route is broken.

    Screenshot 2022-10-24 at 11.23.14
    Screenshot 2022-10-24 at 11.23.14725×459 13.7 KB

3 Likes
9

Thanks for report :+1:

I have a fix under review for this, will let you know when merged.

5 Likes
10

That should fix it: FIX: deleted topic should exclude it from reactions given by jjaffeux · Pull Request #191 · discourse/discourse-reactions · GitHub

Let me know how it goes for you please.

2 Likes
11

This topic was automatically closed 3 days after the last reply. New replies are no longer allowed.