Missing read_more_in_category in latest update

Contribute Bug

AI-generated summary

A bug was introduced in the latest update, causing the read_more_in_category key to be missing. topological encountered the issue and discovered that suggested-topics.js was still referencing the deleted key. JammyDodger confirmed the issue on Meta and suggested fixing it. topological also found missing translations, possibly related to the same issue. However, JammyDodger explained that some missing translations are due to waiting for updates on CrowdIn. The original developer, gerhard, acknowledged the mistake and created a pull request to fix the issue: https://github.com/discourse/discourse/pull/19440.

1

I meet this after updated last night.
image
That is because suggested-topics.js is still using the key read_more_in_category that is deleted in core code in https://github.com/discourse/discourse/commit/3eafa39aeb6769ea46f8e3011c4929635ce1a52c

image
image539×622 54.9 KB

6 Likes
3

I am also seeing this here on Meta:

image
image1422×644 28.3 KB

Let’s see if we can get that fixed up. :+1:

2 Likes
4

Missing translations (can be found in Meta) maybe similar reason.

image
image1041×356 17.6 KB

image
image543×528 17.4 KB

5

The string in the flag modal was updated recently to include ‘to be hateful conduct’ so is likely waiting for an updated translation on CrowdIn. :+1: I’m not on top of the state of translations in general, but if you can see it in English it’s probably in need of a CrowdIn translation, which is slightly different to the issue of the [en_GB…] style ones being visible.

2 Likes
9

Thanks for reporting this. Looks like I deleted from the wrong file by mistake. :blush:

https://github.com/discourse/discourse/pull/19440

5 Likes
[en.topic.read_more_in_category] at the bottom of the suggested topics
10

This topic was automatically closed after 3 days. New replies are no longer allowed.