Setting default site settings and scss based on locale

Contribute Feature
3

Though your guys are busy these days @sam @riking, but I am confused by approach. Can you just go through the code and give me some advice to help me move on? Should roughly take your 5 minutes.

https://github.com/discourse/discourse/pull/3326/files

  • Separate files for override site setting. self.override_default_settings tries to load the default values.
  • self.refresh_defaults! is used to load the overrided the settings.
    • first load the defaults and refresh! to get the default_locale.
    • load the overrides and refresh! to refresh current and containers.
  • when default_locale changed, reload the site setting to get the right default values.

My question is:

  • better to put overrides in one file or merge into site_settings.yml?
  • refresh! twice is weird, but how can I get the right