A recent change in Discourse has improved the handling of YouTube embeds and thumbnails, removing annoying black bars. merefield noticed the change and thanked renato for pointing to the relevant GitHub pull requests (https://github.com/discourse/discourse/pull/20722/files and https://github.com/discourse/discourse/pull/20914). jancernik explained that the change involved modernizing the lazy loading plugin from jQuery and rebaking due to changes in attribute storage, allowing for future compatibility with providers like Vimeo.
Was there a recent change to the way Youtube embeds and thumbnails are handled?
It looks like most videos have lost black bars that were incredibly annoying and forced me to write some additional image processing to remove them.
Also has there been a forced rebake in a recent update?
This is a welcome change, but just wanted some clarity on what happened.
Yes, there’s this recent big change replacing lazy-yt:
https://github.com/discourse/discourse/pull/20722/files
And this one addressing the annoying black bars:
https://github.com/discourse/discourse/pull/20914
Not sure about the forced rebake though.
Thanks @renato I should have delved into the source.
@jancernik this is a really great improvement, thanks!
I’m glad you liked it! The old plugin that was used to handle lazy loading for YouTube was written in jQuery and had some issues. So, we decided to modernize it. The rebake was needed because we made some slight changes in the way we store attributes for the embed, which now allows us to use this type of lazy loading on other providers like Vimeo.
Feel free to reach out if you have more feedback on it.