A discussion is underway regarding the Intrusive dialog when setting a bookmark for a topic. Thomas_DC notices that setting a bookmark for a topic triggers a more intrusive dialog compared to bookmarking a post. He wonders if there’s a setting to change this or if it’s a missing feature.
After testing, Thomas_DC shares his observations and suggests that either separate bookmarks for posts and topics should be displayed, or the second bookmark should edit the first.
supermathie attributes the recent changes to a commit by martin and joffreyjaffeux. He explains that topic and post bookmarks are treated separately, with topic bookmarks going to the last read post.
Martin updates the user on the changes, stating that the topic footer button now uses a quick menu instead of a modal, and that the modal is only shown when editing the bookmark or choosing a custom reminder option. He also mentions plans to overhaul the modal in the near future.
When I set a bookmark for a post, it’s far less intrusive than the intrusive dialog which was prompted sooner.
But, when I set a bookmark for a topic, it’s the same intrusive dialog than sooner.
Is there a setting for that, or is it a missing which I should report as a bug or as a feature?
I don’t know if it’s you, @supermathie , who made the correction, anyway thank you very much to whoever did it.
BTW:
Before replying, I made 2 bookmarks, one for the post, and one for the topic. (i don’t know if you can see them.)
I don’t see any difference between them.
Depending on how this feature have been designed:
either I should see a bookmark for a post, and another for a topic, even if they point on the same place,
or when I clicked to make the 2nd, it should edit the 1st instead.
I guess you are testing new features here, before making them available to other places where Discourse is used.
Well, take a look also at synchronization when making bookmarks using keyboard shortcut instead of bookmark buttons.
They are separate and should be treated separately. The topic bookmark is for the topic itself and goes to… looks like the last read post… while a post bookmark goes to that specific post.
We’ve now made it so the topic footer button that bookmarks the topic itself uses the new quick menu instead of the modal. The modal is now only shown if you edit the bookmark or chose the “Custom…” reminder option.
We are also intending to overhaul this modal in the near future, so stay tuned. Glad you’re enjoying the new functionality!