`run_second_factor!` failing when trying to promote admin

sam · July 1, 2024, 9:50pm

Not seeing how result can be undefined given:

discourse/discourse/blob/9e8d8d37fa7426f6a31a657dcdbd21460b3a91c4/lib/second_factor/auth_manager.rb#L168-L182


      
          def run!(request, params, secure_session)
            if nonce = params[:second_factor_nonce].presence
              data = verify_second_factor_auth_completed(nonce, secure_session)
              create_result(:second_factor_auth_completed, data)
            elsif @action.skip_second_factor_auth?(params)
              data = @action.second_factor_auth_skipped!(params)
              create_result(:second_factor_auth_skipped, data)
            elsif !allowed_methods.any? { |m| @target_user.valid_second_factor_method_for_user?(m) }
              data = @action.no_second_factors_enabled!(params)
              create_result(:no_second_factor, data)
            else
              nonce = initiate_second_factor_auth(params, secure_session, request)
              raise SecondFactorRequired.new(nonce: nonce)
            end
          end

github.com

discourse/discourse/blob/9e8d8d37fa7426f6a31a657dcdbd21460b3a91c4/lib/second_factor/auth_manager.rb#L233-L235


      
          def create_result(status, data = nil)
            SecondFactor::AuthManagerResult.new(status, data)
          end

Are you absolutely sure you are on absolute latest?

Topic		Replies	Views
Can't upgrade user to admin - unhandled server error support	11	499	September 6, 2023
New admins can't enroll 2FA when enforce second factor is set to Staff bug	9	386	November 25, 2023
Cannot disable 2FA for User support	6	761	March 7, 2021
Admin Account Security Best Practices? support	6	686	March 1, 2021
Requiring password before admin actions can be taken feature	4	1695	February 26, 2018

`run_second_factor!` failing when trying to promote admin

Related Topics