More data in user approval

Contribute Feature

AI-generated summary

The discussion More data in user approval started with ganncamp suggesting that it would be helpful to display IP addresses and a lookup button in the user review queue to combat spam. JammyDodger recommended a theme component, discourse-review-ip-lookup, which ganncamp installed but couldn’t get to work. After some troubleshooting with JammyDodger, it was discovered that the component doesn’t support user approvals. fzngagan updated the theme component and mentioned that the backend doesn’t currently support sending IP addresses for user reviewables. Overgrow requested that the component be styled for mobile devices. Eventually, fzngagan announced that the feature has been merged into core Discourse, making the theme component unnecessary. @pfaffman suggested that a linting rule be implemented to require theme components to have a description in their about.json file.

1

As one strategy to combat a current spam wave, we’ve enabled user approval.

When I’m looking at a as-yet-unapproved user, I see only the info they filled in in the signup form:

Selection_1998
Selection_1998807×634 32.6 KB

But we’ve realized that the problem is coming from a specific subset of IPs and those IPs generally resolve to one of two companies. So for nearly every user, I end up clicking through to see the IP and then doing a lookup on it.

Selection_1999
Selection_1999735×333 28.5 KB

And then I go back to the review queue to either approve or delete

It would be really helpful if the IP and the lookup button were presented in the review queue. :awthanks:

2 Likes
2

I think we have theme component for that you can install. :+1:

https://github.com/discourse/discourse-review-ip-lookup

Not sure it has a meta topic?

6 Likes
4

Or a description in the repo :sweat_smile:

Nonetheless, I’ve installed it, but I’m not seeing any change, even in the component preview. Even after a hard refresh.

Selection_2003
Selection_20031117×765 65.9 KB

Did I miss a button somewhere?

Selection_2002
Selection_2002786×584 41.2 KB

2 Likes
5

Hmm :thinking: It seems to be working for me on my test site:

Untitled
Untitled999×740 49.5 KB

Though now you mention it, I’m not sure I see it in our review queue here on meta (and it is installed).

3 Likes
6

And… you’re seeing it on a post and not (necessarily) on a user?

ETA: Altho… I’m not sure where in your screenshot I should be looking to see the IP lookup?

2 Likes
8

No, I’ve spotted what it is for meta. It doesn’t show on reviewables that now have deleted users (I remember it borking out when it tried previously). I can see it if I scroll to an eligible one.

Let me check a user approval one on my test site. :eyes:

(and I put a better screenshot in the post above)

No, you’re right. It doesn’t seem to be appearing for a user approval reviewable. Let me see if that’s intended…

2 Likes
10

I really think that a linting rule requiring something in about.json and/or not having the default readme.md would be a good idea. Maybe have it triggered by setting a non-default version number? And then a Best Practice would be to set some version number before the thing was deployed (otherwise, one would be required to make up something that’s completely bogus before they made their first commit?).

2 Likes
13

Hey @ganncamp
I’ve updated the theme component to bring it at par with the Discourse updates. Although the support for User Reviewable isn’t there still as the Backend doesn’t support sending the IP address of the User Reviewable currently. I’ll discuss internally and let you know what we think about this change.

4 Likes
14

Would it be possible to style it properly for the mobile too? Currently the ip lookup modal is completely out of the viewport in the post review screen. Thanks!

2 Likes
15

@fzngagan your PR title is

FIX: mordernise js, prevent display on ReviewableUser (#5)

Did you really want to prevent display on users?

Because it’s already not there.

Also, when you said this:

I kinda assumed that meant adding a repo description :sweat_smile:

1 Like
16

Just until the backend provides the IP address. Not meaning to keep it that way.

I’ll get to it soon.

1 Like
17

Hi @ganncamp
The good news is, this feature is merged into core Discourse so you no longer need the theme component for this.

5 Likes