I am happy that large image uploads are now being resized, but its not taking a 4.6MB image down to 1MB - I recently set the max image size to 1024K and tried uploading a 4.6MB image and got a too-large error. Looking at the code it is doing a 80%-resize up to 2 times and if its not small enough by…

Because there’s no way to 1) predict how long a downsize operation will take and 2) know what % we need to use to downsize a xMB image to 1MB image. If you know the answer to either one of those points, please share :raised_hands: So we do it the hard way. We indeed only do 2 80-%-downsizes. From …

Yes, in thinking about it its harder than I was expecting. Here is a Stack Overflow post with some good ideas: [Pablo Fernandez] How to resize an image in C# to a certain hard-disk size? c#, image, image-processing, image-manipulation asked by Pablo Fernan…

Following up on my old post here.. I noticed after a recent update we were not getting any resizing to work. In looking at the code, there are a couple of recent commits to uploads_controller.rb that look like it broke the resizing. One is loop exit condition break if downsized_size >= uploaded_s…

Sure @zogstrip can have a look.

Thanks for all your suggestions! They’re now implemented :wink: https://github.com/discourse/discourse/commit/7fca6f502ffaaccbeda7453ec743625690fdb051

Cool! Code looks great now. I will give it some tests on my dev server at some point. The ratios I picked in the table were based on eyeball calculations so they may not be perfect. But they should not be too far off.

[image] scottfsmith: The ratios I picked in the table were based on eyeball calculations so they may not be perfect. But they should not be too far off. It’s fine, we can iterate on it :wink:

Update: I patched my production site with the revised code and all is working good for a day now :smile: I set the max size to 2mb and many images are getting resized. Now that I worked on this I belatedly noticed you un-deprecated the Amazon S3 image storage option. So, its much less of a life-o…

Large image resize - why only 64% scaling at most?

Support

zogstrip January 22, 2016, 6:33pm 4

I’d happily merge a PR replacing the hardcoded-80-% with a decent heuristic

Topic		Replies	Views
Resizing images after upload settings Self-hosting	25	5171	April 17, 2022
Unable to resize images after uploading Bug	4	2114	August 17, 2015
Image upload max size and further resizing regression issue Feature	16	4584	May 3, 2018
Image upload error when using resizer Bug	7	2230	March 25, 2020
Image upload size/resize question Support	24	6219	April 4, 2021

Large image resize - why only 64% scaling at most?

Related topics