管理者がモデレーターでない場合にフラグ通知を表示しない設定を追加

Lilly · 2026 年 7 月 9 日午前 5:27

まあ、気分転換に——フラグ通知を Moderators グループのメンバーにのみ送信するようにするPRをここに開きました（上記のオプションB）。つまり、Moderators グループのメンバーではない Admins は、フラグに関する通知やインジケーターを受け取らなくなります。もちろん、サイドバーからいつでもレビューキューにアクセスすることはできます。

いつものように、いくつかのPRテスト（おそらくlinting）が失敗すると思います。lol

昔からの友人 triage-bot が直してくれるはずです

github.com/discourse/discourse

UX: Restrict active reviewable notifications and badges to moderators (#41580)

main ← Lillinator:flags-notify-mods

closed 05:14PM - 09 Jul 26 UTC

Lillinator

+18 -4

## What is the purpose of this Pull Request? Currently, Discourse broadcasts re…view queue notifications (flags, queued posts) to the entire `staff` group. This results in significant notification noise for "pure Admins" who are not members of the Moderator group, and thus, not involved in the day-to-day moderation of the community. Following the discussion on Meta here: https://meta.discourse.org/t/add-setting-to-not-show-flag-notification-to-admins-who-are-not-moderators/383964/5 This PR makes flags only notify the Moderators group instead of staff; thus, Admins not in the moderators group are not notified of flags nor see a review queue count indicator in sidebar (they can still go to the review queue manually as usual). That is, it mutes the active UI elements for pure Admins while preserving their underlying permission to access and action the review queue if they choose to. ### Technical Implementation: This PR intercepts the reviewable counts at the Model and Serializer layers to securely silence the frontend without modifying underlying database permissions or the core `/review` route. 1. **Websockets & Live Updates:** * Scoped `notify_users` to `moderators` instead of `staff` to prevent live browser "pops" for admins. * Updated `publish_reviewable_counts` to push `0` counts to pure admins. 2. **UI Badges & Preloaders:** * Overrode `unseen_reviewable_count` and `reviewable_count` in `CurrentUserSerializer` to clear the red avatar flag, the blue menu badge, and the sidebar count for pure admins. * Intercepted `Reviewable.user_menu_list_for` to return an empty array for non-moderators, effectively silencing the `<meta>` tag preloader and the user menu dropdown API. 3. **Tests:** Updated `refresh_users_reviewable_counts_spec` to expect `0` for admin payloads. *(Note: CI is running, will update any other strictly `staff`-scoped spec expectations as needed!)* ### Testing Performed: Manually verified on a live development install with three distinct user roles: - [x] **Pure Admin (Admin = true, Moderator = false):** Receives 0 websocket pops, no red avatar badge, no blue menu badge, and an empty menu dropdown. Can still successfully manually navigate to `/review` and action pending flags. - [x] **Pure Moderator (Admin = false, Moderator = true):** Behavior remains exactly as it was. Fully receives websockets, badges, and dropdown items. - [x] **Hybrid Staff (Admin = true, Moderator = true):** Behavior remains exactly as it was (receives all notifications). - [ ] **Category Moderators:** not tested yet. ### Files Touched: * app/models/reviewable.rb * app/models/user.rb * app/serializers/current_user_serializer.rb * app/controllers/reviewables_controller.rb * spec/jobs/refresh_users_reviewable_counts_spec.rb * spec/requests/reviewables_controller_spec.rb

追記：Moin、カテゴリモデレーターのことなんて気にしてないよ

トピック		返信	表示
Dismiss Admin Noise! Theme component notifications	5	263	2026 年 7 月 8 日
Moderators no longer see new flagged posts Bug	10	1393	2019 年 4 月 5 日
Alert Admin/Mod when a Topic or Post is Flagged Support	2	677	2024 年 8 月 26 日
Does anyone get notified when something is flagged? Support	25	4730	2016 年 2 月 12 日
Admin versus Moderator and Groups Feature moderation	7	3139	2024 年 8 月 9 日

管理者がモデレーターでない場合にフラグ通知を表示しない設定を追加

関連トピック