비활성화된 플러그인도 여전히 성능에 영향을 줍니다

Since a lot of plugins have been bundled with core, we’ve been seeing some performance impact.

When investigating, it turned out that some plugins are still injecting certain queries, even when disabled.

An example is the topic voting plugin.

The topic filter and the search filter and search order are always injected and active.

The code should be fenced with SiteSetting.topic_voting_enabled. Or maybe calls like register_search_advanced_filter should behave more like add_to_serializer and check if the plugin is enabled.

14개의 좋아요

Thank you for the report. I’ve tagged this pri-medium for now and someone from the team will look at it soon.

Also putting a pr-welcome on this :slight_smile:

4개의 좋아요

I just finished a PR making most of the `register_*` calls behave like add_to_serializer:

https://github.com/discourse/discourse/pull/35630

4개의 좋아요

The PR has just been merged, it should be available in latest shortly :slight_smile:

3개의 좋아요

Thanks, that is fantastic :heart_eyes:
Would a backport to stable be a possibility for this fix ?

3개의 좋아요

Sure, I just created a PR:

https://github.com/discourse/discourse/pull/35703

3개의 좋아요