The discussion revolves around why the Discourse GIFs component uses appEvents instead of toolbarEvent when adding GIFs. NateDhaliwal questions the design choice, noting that toolbarEvent could be passed in at the action level. He explores the code and finds that the modal is also launched from outside the toolbar, which explains the use of appEvents. david confirms this, clarifying that the modal’s broader usage outside the toolbar justifies the current implementation. NateDhaliwal acknowledges the explanation and thanks the clarification.
I was looking at the gifs TC yesterday, and I noticed this block of code:
Where it uses the appEvents service. The thing is, why can’t toolbarEvent be passed in at the action?
I’ve tried it and it seems to work. Was there a reason why that was not used?
Considering it uses TextManipulation under the hood, there seems to be a insertText method.
Just curious.
Thanks.
Digging a bit further, I found this line:
So… the app event still performs the same as textManipulation? What would be the added advantage in the TC?
Anyone has any ideas? I’m considering the appEvent versus toolbarEvent, and knowing the differences (if any) would be helpful.
I think discourse-gifs does it like this because the Modal is also launched from outside the toolbar:
If your new thing is entirely toolbar-based, then I agree toolbarEvents is the cleaner way to go 
Ah, that’s it. Thanks for clarifying, I’ll go ahead with toolbarEvent then.