Labels and descriptions missing from nested object settings

AI-generated summary

In a bug report titled “Labels and descriptions missing from nested object settings,” Lilly identified an issue where setting labels and descriptions fail to display correctly in the theme admin UI for nested object type configurations. While first-level settings render as expected, subsequent levels incorrectly use the setting name as the label and omit descriptions entirely, deviating from the defined en.yml translations. awesomerobot acknowledged the report and confirmed a fix is in the queue via PR #37538. Lilly subsequently verified the resolution, sharing a screenshot showing that labels and descriptions now appear correctly in the nested settings.

:information_source: Overview

ref: Objects type for theme setting

Setting labels and descriptions are not showing up in theme admin UI for nested object type settings. The labels appear to be using the setting name instead.

:person_walking: Reproduction steps:

  1. Install any theme component that has a nested object type setting and descriptions in proper en.yml syntax.
  2. Go to the first level object type setting - notice the setting labels and descriptions are displayed as expected.

  1. Now go to next level - the labels are incorrect and the descriptions are not there.

relevant section of /locales/en.yml

:cross_mark: Observed result:

After first level of object type setting schema, the setting labels are not the same as what is in en.yml and the descriptions are missing. The labels are probably using the setting names.

:white_check_mark: Expected result:

Setting labels and descriptions are consistent with what is in the /locales/en.yml file (and the other translation .yml files).

4 Likes

Good catch! I have a fix in the queue

https://github.com/discourse/discourse/pull/37538

3 Likes

much better - thanks! :smiley:

2 Likes