更改 Enable 表单模板的目标受众会在左侧边栏中错误地创建一个“更新 Discourse”选项

Noble_Fish · 2026年三月11日 11:32

5a02ff
v2026.3.0-latest +331

zogstrip · 2026年三月24日 15:39

感谢您的报告 @Noble_Fish

@martin 您对这个修复有什么看法？

github.com/discourse/discourse

FIX: Admin sidebar links corrupted when toggling upcoming changes (#38828)

main ← fix/admin-sidebar-links-corrupted-on-setting-toggle

opened 03:39PM - 24 Mar 26 UTC

ZogStriP

+87 -46

The admin sidebar's `@cached` `sections` getter calls `amendLinksToSection` on `…AdminNavManager`, which permanently mutates its internal `#adminNavMap`. When the getter re-evaluates (e.g. after toggling the `enable_form_templates` upcoming change via MessageBus), links accumulate: they persist after a setting is turned off and duplicate on repeated toggles. This happens because `amendLinksToSection` pushes to the persistent `#adminNavMap` array, and there was no mechanism to reset it between evaluations. The fix adds a `resetNavMap()` method to `AdminNavManager` and calls it at the start of each `sections` evaluation, ensuring a clean slate. This also makes the existing dedup guards (plugin link filtering, `linkExists` check for upcoming_changes) redundant, so they are removed along with an unnecessary closure wrapper for login route links. https://meta.discourse.org/t/398151

martin · 2026年三月25日 03:40

非常感谢 Regis @Noble_Fish 修复程序现已合并，抱歉花了这么长时间。

話題		回覆	觀看
New Admin Sidebar...where's the Update Discourse button? Bug admin-sidebar	14	512	2024年五月19日
Navigation links added by plugins and theme components are missing Bug	3	613	2022年六月14日
Custom menu links are modified and broken by Discourse Bug	7	583	2024年三月20日
Settings layout Support admin-sidebar	3	281	2024年十月29日
Admin Panel Changes Support	2	184	2024年八月17日

更改 Enable 表单模板的目标受众会在左侧边栏中错误地创建一个“更新 Discourse”选项

相關主題