Enable form templates의 대상 청중을 변경하면 왼쪽 사이드바에 Update Discourse 옵션이 잘못 생성됩니다

zogstrip · 3월 24, 2026, 3:39오후

보고해 주셔서 감사합니다 @Noble_Fish

@martin 이 수정안에 대해 어떻게 생각하시나요?

github.com/discourse/discourse

FIX: Admin sidebar links corrupted when toggling upcoming changes (#38828)

main ← fix/admin-sidebar-links-corrupted-on-setting-toggle

merged 03:40AM - 25 Mar 26 UTC

ZogStriP

+87 -46

The admin sidebar's `@cached` `sections` getter calls `amendLinksToSection` on `…AdminNavManager`, which permanently mutates its internal `#adminNavMap`. When the getter re-evaluates (e.g. after toggling the `enable_form_templates` upcoming change via MessageBus), links accumulate: they persist after a setting is turned off and duplicate on repeated toggles. This happens because `amendLinksToSection` pushes to the persistent `#adminNavMap` array, and there was no mechanism to reset it between evaluations. The fix adds a `resetNavMap()` method to `AdminNavManager` and calls it at the start of each `sections` evaluation, ensuring a clean slate. This also makes the existing dedup guards (plugin link filtering, `linkExists` check for upcoming_changes) redundant, so they are removed along with an unnecessary closure wrapper for login route links. https://meta.discourse.org/t/398151

글		댓글	조회수
New Admin Sidebar...where's the Update Discourse button? Bug admin-sidebar	14	470	5월 19, 2024
Navigation links added by plugins and theme components are missing Bug	3	596	6월 14, 2022
Custom menu links are modified and broken by Discourse Bug	7	578	3월 20, 2024
Settings layout Support admin-sidebar	3	251	10월 29, 2024
Admin Panel Changes Support	2	176	8월 17, 2024

Enable form templates의 대상 청중을 변경하면 왼쪽 사이드바에 Update Discourse 옵션이 잘못 생성됩니다

Related topics