Experiencia de Tecnoblog con los comentarios de Discourse

Falco · 16 Abril, 2026 17:35

Gracias por la prueba, encontré el problema

github.com/discourse/discourse

FIX: Use iframe style.height for embed resize messages (#39321)

main ← fix/embed-dynamic-height-inline-style

opened 05:34PM - 16 Apr 26 UTC

xfalcox

+1 -1

## Summary When Discourse is loaded in full app embed mode with `dynamicHeight:… true`, the iframe was not resizing in production despite `discourse-resize` messages arriving correctly. The full app path sets `iframe.style.height` as an inline style for the initial height. Inline styles always win over the `height` HTML attribute, so our resize handler — which set `iframe.height = ...` — had no visible effect. This changes the resize handler to set `iframe.style.height` so it actually overrides the inline style. This also works for the standard (non-full-app) embed path since no inline style is set there initially. ## Test plan - [ ] Full app embed with `dynamicHeight: true` — verify iframe height updates as content loads - [ ] Standard (non-full-app) embed — verify iframe still resizes correctly - [ ] CSS `max-height` on the iframe still wins (inline `height` doesn't override `max-height`)

Tema		Respuestas	Vistas
Embed Discourse comments on another website via Javascript Integrations embedding , how-to	128	302709	26 Mayo 2026
Embed Discourse as a full comment system on your site Announcements embedding	23	1523	6 Mayo 2026
Embed Discourse comments with on-page commenting? Feature	32	8030	19 Enero 2019
Should Discourse make an effort to become a viable comment platform? Community Building	63	5018	25 Marzo 2026
Discourse Comments stuck on "Loading..." Support	22	2169	18 Septiembre 2024

Experiencia de Tecnoblog con los comentarios de Discourse

Temas relacionados