无法在自定义侧边栏部分配置对话框中按名称搜索图标

zogstrip · 2026年四月20日 09:57

干得漂亮 @Lilly

这看起来是最近的回归问题，应该已在以下 PR 中修复：

github.com/discourse/discourse

FIX: Allow typing inside float-kit menus rendered from within a modal (#39370)

main ← fix-icon-picker-filter-in-modal

opened 09:56AM - 20 Apr 26 UTC

ZogStriP

+43 -5

`DModal` listens for `keydown` on `documentElement` in the capture phase and can…cels events whose `activeElement` is not inside the modal wrapper, to prevent keyboard shortcuts from leaking to the page behind the modal. Since `DIconGridPicker` replaced the select-kit `IconPicker` in the custom sidebar section modal (#38943), the picker's filter input renders inside the `#d-menu-portal-outlet` portal — outside the modal DOM — so every keystroke was cancelled and typing silently failed. Allow keydown through when `activeElement` is inside a float-kit portal (`.fk-d-menu`, `.fk-d-menu-modal`, `.fk-d-tooltip`), which covers any menu/tooltip opened from within a modal without weakening the leak guard for elements actually behind the modal. Also adds a system spec that catches this with real keyboard typing (the existing `icon_picker.filter` helper used `fill_in` + clicked the target icon which was already visible without filtering, so the bug slipped past the suite). https://meta.discourse.org/t/400945

（抄送 @saquetim）

話題		回覆	觀看
Icon picker search doesn't support capital letters UX fixed	1	145	2026年八月19日
How to choose icons for links in custom section UX sidebar	10	635	2026年八月14日
Search Icon can appear outside drop-downs Bug	3	642	2018年五月15日
Preactivate the search field of the GIF search UX chat , gifs	7	214	2025年一月8日
Search icon covers search input Site feedback search , ux	4	164	2026年八月29日

无法在自定义侧边栏部分配置对话框中按名称搜索图标

相關主題