In a server-side ruby plugin, I’m using DiscourseEvent.on("post_created") to get data on post replies. However, this is also being triggered when a person replies to a private message. Unfortunately, I can’t see any attributes on the event objects that allow me to distinguish a reply to a topic from…

Something might be wrong, because the topic.archetype == "private_message" is the way to differentiate regular posts from PMs.

Yea, I’m seeing the initial PM come through with that archetype, but replies after the initial message are “regular”.

But the archetype is on the topic, not on the post. I just tried a new PM on my dev instance and the archetype is private_message.

[图片] Falco: I just tried a new PM on my dev instance and the archetype is private_message. Yea, but what about subsequent messages in the PM conversation? Those have regular. edit: I’m testing on 1.7.0.beta5

[图片] tim.smith: Yea, but what about subsequent messages in the PM conversation? Those have regular. But isn’t the archetype on the topic instead of the post? In the database there is only one line per topic, and it’s set correctly. Where are you testing this info?

Here’s the code that I’m using to trace out the event objects: Discourse-Webhooks/plugin.rb at master · purecloudlabs/Discourse-Webhooks · GitHub Here’s the result of that trace for a PM reply. I believe the topic is the second object in the params array. I’ve truncated the user object for brevity. …

Hmmm I think this params variable isn’t used elsewhere. And on brand new official WebHooks for post created we only send down the topic id.

[图片] Falco: Hmmm I think this params variable isn’t used elsewhere. The params variable is the name of the variable in my plugin, not something in Discourse. It’s an array of the 3 parameters passed into a Discourse event, presumably via DiscourseEvent.trigger(...). Here’s where it’s defined …

[图片] tim.smith: . I’m consuming events in my plugin that are raised by Discourse directly, parsing/formatting the event data, and sending my own webhook. In that case, you need to add post.topic.archetype as a field that gets sent. Or, do Guardian.new(plugin _user).can_see? post and use the …

you need to add post.topic.archetype as a field that gets sent. What do you mean? The field is there in the event data for PM replies. It’s just set to “regular” so I can’t distinguish it from a reply to a topic. Or, do Guardian.new(plugin _user).can_see? post and use the standard visibility ch…

Distinguish private messages from posts?

Development

tim.smith (Tim) 2016 年10 月 13 日 17:04 17

Seriously? What’s the point of sending data with an event if you shouldn’t use it or can’t rely on it being accurate? That’s really poor design.

话题		回复	浏览量
Webhooks: how best to differentiate a PM from a public post Development webhooks	12	1529	2019 年9 月 24 日
PM replies have wrong archetype Bug pr-welcome	1	975	2016 年11 月 22 日
Discourse webhook displays private messages Product Support	3	1405	2018 年6 月 26 日
Discourse Private Replies Plugin	60	9348	2026 年4 月 20 日
Making a difference between public topic and private message on API Feature	3	614	2019 年2 月 1 日

Distinguish private messages from posts?

相关话题