Email template titles not translated

Contribute Translations

AI-generated summary

claas has identified two translation problems with the Email templates in Discourse. The first issue is that the titles of email templates are not translated, which is caused by the AdminEmailTemplateSerializer only “titleizing” the keys of the email templates (claas). claas has submitted a PR to solve this problem (claas).

The second issue is that four email templates are missing in I18n, but claas has discovered that these are actually artifacts that have been replaced or removed in previous commits (claas). claas has submitted another PR to remove these artifacts (claas).

1

I noticed two translation problems with the Email templates in the Administration → Customize → Email templates section.

1. Titles of email templates are not translated:

Clarification: The title of an email template is not its subject.

image.png477×423 10.3 KB

This is because the AdminEmailTemplateSerializer only “titleizes” the keys of the email templates (e.g. system_messages.bulk_invite_failed becomes Bulk Invite Failed) here:

2. Four email templates are missing in I18n:

Update: Looks like artifacts, as not referenced anywhere (added links to GitHub search).

image.png640×503 10 KB

3 إعجابات
2

Here’s the PR for solving the first problem:

https://github.com/discourse/discourse/pull/4636

4 إعجابات
3

Was replaced by email_reject_bad_destination_address here.

Was removed here.

Was replaced by email_reject_invalid_post_specified here.

Was replaced by email_reject_insufficient_trust_level here.

In short: We can remove these.

https://github.com/discourse/discourse/pull/4638

P.S.: This advice helped.

4 إعجابات