The discussion revolves around issues with whitelisting iframes from Facebook on a Discourse forum after updating to version v1.9.0 beta4. Bank_Live attempted to use various plugins, including https://github.com/evil-shrike/discourse-whitelist-iframe.git, but encountered errors.
simon explained that the original plugin’s issue was due to Discourse.dialect_depreciated no longer being defined and offered an updated fix. However, he also mentioned that the plugin is no longer required as iframes can be whitelisted through the allowed_iframes Site Setting.
sam noted that the old API for whitelisting iframes has been removed, and plugins should use the site settings instead. tophee inquired about the site setting’s functionality and whether it supports regex, to which sam replied that it only understands prefix and not regex.
tophee shared an example of a complex regex pattern and sam suggested that it could be achieved “the long way” without regex by specifying domains or subdomains explicitly.
Thanks! I wrote the original version of that plugin. It looks like the problem with the latest version of Discourse is that that Discourse.dialect_depreciated is no longer defined. I’ve pushed a fix to my repo that should take care of the problem.
To use it with the facebook URL, you’ll need to clone the repo and add the facebook URL to the list of whitelisted iframes. You can copy how to do that from one of the repos you listed above.
This plugin has been cloned 54 times. Because of problems with updates, I regret having shared it on this forum. It seems there is a demand to be able to use iframes on some forums. Maybe there is a better way that this could be approached.
Note: this plugin is no longer required. iframes can now be whitelisted through the allowed_iframes Site Setting. It accepts a list of iframe src domain prefixes that discourse can safely allow in posts.
It looks like it’s installed. Does it work? Try the iframe code from a YouTube video to test it. If you have cloned my repository, it does not include the facebook URL
I am currently using the whitelist iframe plugin. Does this mean is will cease to work once I upgrade my discourse and that I will instead find a site setting where I can specify a list source domains that are safe? Does that setting understand regex?
Yeah the long way for now, I am mixed about allowing people regexes in site settings cause it is so easy to muck it up. Not strictly against, just wanted to see some use cases.
I mean you have to be explicit: https://somesite.com/embed? will work. You can specify domains or subdomains.